[kde-doc-english] Review Request 127820: Fix kdesrc-build docbook

[Michael Pyne]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127820/#review95146
-----------------------------------------------------------



Thanks for the patch, looks like I have much more work to do with the docs. :(


doc/index.docbook (line 115)
<https://git.reviewboard.kde.org/r/127820/#comment64568>

    16.05 is accurate (I updated the script, looks like I've forgotten that was there for awhile). The rest of the requested change here is fine.



doc/index.docbook (line 3433)
<https://git.reviewboard.kde.org/r/127820/#comment64569>

    http://code.qt.io/cgit/qt/ is probably the best replacement, although we now mirror many of the important Qt modules (without changes) within the KDE repository... but there's probably not much benefit to mentioning that.



doc/man-kdesrc-build.1.docbook (line 26)
<https://git.reviewboard.kde.org/r/127820/#comment64570>

    16.05 is the right version (it's date-based now).


- Michael Pyne


On May 3, 2016, 8:27 a.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127820/
> -----------------------------------------------------------
> 
> (Updated May 3, 2016, 8:27 a.m.)
> 
> 
> Review request for Documentation and Michael Pyne.
> 
> 
> Repository: kdesrc-build
> 
> 
> Description
> -------
> 
> adapt header to doctools.git / src / templates
> set version to 15.05 because that's in Version.pm $VERSION = '15.05' (bump because "--query flag"?)
> fixed wrong + outdated links
> add some fixme's where the docbook seems to be wrong or outdated
> 
> 
> Diffs
> -----
> 
>   doc/index.docbook 6a83d21 
>   doc/man-kdesrc-build-setup.1.docbook 3daefa1 
>   doc/man-kdesrc-build.1.docbook 27745cb 
> 
> Diff: https://git.reviewboard.kde.org/r/127820/diff/
> 
> 
> Testing
> -------
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20160504/2863110c/attachment.html>