[kde-doc-english] Review Request 128096: add man page for kaffeine

Mauro Carvalho Chehab mchehab at infradead.org
Tue Jun 7 21:25:45 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128096/#review96266
-----------------------------------------------------------


Ship it!




Version 2 is OK!

A side note: On version 2.0.2, I added the Kaffeine version at CListMake.txt, and added some logic to auto-updte the version when cmake is called:
    configure_file(config-kaffeine.h.cmake ${CMAKE_BINARY_DIR}/config-kaffeine.h)
    (at src/CMakeLists.txt)

Maybe we could use it too for the man and doc files. What do you think?

- Mauro Carvalho Chehab


On June 7, 2016, 7:35 p.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128096/
> -----------------------------------------------------------
> 
> (Updated June 7, 2016, 7:35 p.m.)
> 
> 
> Review request for Documentation and Mauro Carvalho Chehab.
> 
> 
> Repository: kaffeine
> 
> 
> Description
> -------
> 
> add new man page
> debian policy requires it anyway
> this should replace the outdated sect in the handbook
> 
> 
> Diffs
> -----
> 
>   doc/CMakeLists.txt 06f05fb 
>   doc/man-kaffeine.1.docbook PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128096/diff/
> 
> 
> Testing
> -------
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20160607/e96de721/attachment.html>


More information about the kde-doc-english mailing list