Review Request 129621: proofread/update kalarm docbook for kf5
David Jarvie
djarvie at kde.org
Fri Dec 9 23:26:31 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129621/#review101347
-----------------------------------------------------------
doc/index.docbook (line 731)
<https://git.reviewboard.kde.org/r/129621/#comment67863>
three -> two
doc/index.docbook (line 976)
<https://git.reviewboard.kde.org/r/129621/#comment67864>
This *is* in kf5. The option only appears after Set Color has been used.
doc/index.docbook (line 4745)
<https://git.reviewboard.kde.org/r/129621/#comment67865>
This doesn't exist in kf5.
doc/index.docbook (line 4760)
<https://git.reviewboard.kde.org/r/129621/#comment67866>
To confirm, the calendar file names created on first run are fixed, so references to the config file option overrides should be removed.
doc/index.docbook
<https://git.reviewboard.kde.org/r/129621/#comment67867>
This paragraph should be retained (although I need to review the INSTALL file contents).
- David Jarvie
On Dec. 6, 2016, 2:06 p.m., Burkhard Lück wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129621/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2016, 2:06 p.m.)
>
>
> Review request for Documentation, KDEPIM and David Jarvie.
>
>
> Repository: kalarm
>
>
> Description
> -------
>
> remove entities kappname + package, not used in kf5
> bump date + releaseinfo
> replace &kde; with &plasma; or remove &kde;
> comment some options not found here, see FIXME
> add missing option --triggerEvent
> replace Help options with qt5options + kf5options
> remove KResources related stuff
> remove &reporting.bugs; + &updating.documentation;, not used in kf5
> fix path for kalarm files
> remove appendix installation, outdated
> update screenshots
>
>
> Diffs
> -----
>
> doc/index.docbook 3592408
>
> Diff: https://git.reviewboard.kde.org/r/129621/diff/
>
>
> Testing
> -------
>
> checkXML5 index.docbook
>
>
> File Attachments
> ----------------
>
> alarmmessage.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/12/06/804ca7df-7a12-45bb-82a2-22289b92a4fd__alarmmessage.png
> editwindow-simple.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/12/06/90b049bb-2a16-4101-bec1-ac47128ac378__editwindow-simple.png
> editwindow.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/12/06/dbee9aa3-d534-4c6a-b0cc-c1bb1011ba43__editwindow.png
> mainwindow-calendars.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/12/06/eebca392-d8b4-4a31-ba29-8c6c6409fb26__mainwindow-calendars.png
> mainwindow.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/12/06/da1682d0-ebf2-476e-818c-4a25d0dfdc4f__mainwindow.png
>
>
> Thanks,
>
> Burkhard Lück
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20161209/2c8b396c/attachment.html>
More information about the kde-doc-english
mailing list