[kde-doc-english] Review Request 127707: Update kwrite + katepart menu docbook

Dominik Haumann dhaumann at kde.org
Sun Apr 24 09:26:59 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127707/#review94805
-----------------------------------------------------------


Fix it, then Ship it!




Looks good, I have minor comments, but not sure whether these are really issues, therefore fine for me to commit.


doc/katepart/fundamentals.docbook (line 85)
<https://git.reviewboard.kde.org/r/127707/#comment64404>

    Comma missing after the first </option>_,_
    
    Or is that on purpose?



doc/katepart/fundamentals.docbook (line 97)
<https://git.reviewboard.kde.org/r/127707/#comment64405>

    no idea for the use case :-p



doc/katepart/fundamentals.docbook (line 105)
<https://git.reviewboard.kde.org/r/127707/#comment64406>

    comma missing?



doc/katepart/fundamentals.docbook (line 113)
<https://git.reviewboard.kde.org/r/127707/#comment64407>

    comma missing?



doc/katepart/fundamentals.docbook (line 121)
<https://git.reviewboard.kde.org/r/127707/#comment64408>

    comma missing?



doc/katepart/fundamentals.docbook (line 129)
<https://git.reviewboard.kde.org/r/127707/#comment64409>

    comma missing?



doc/katepart/menus.docbook (line 351)
<https://git.reviewboard.kde.org/r/127707/#comment64410>

    `between an` or `between a`



doc/katepart/menus.docbook (line 508)
<https://git.reviewboard.kde.org/r/127707/#comment64411>

    It is Ctrl+Shift+6, and not Ctrl+Shift+G


- Dominik Haumann


On April 22, 2016, 2:32 p.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127707/
> -----------------------------------------------------------
> 
> (Updated April 22, 2016, 2:32 p.m.)
> 
> 
> Review request for Documentation and Kate.
> 
> 
> Repository: kate
> 
> 
> Description
> -------
> 
> proofread + update
> 
> 
> Diffs
> -----
> 
>   doc/katepart/fundamentals.docbook b4a4d5c 
>   doc/katepart/menus.docbook 3b6efad 
>   doc/kwrite/index.docbook d336a4d 
> 
> Diff: https://git.reviewboard.kde.org/r/127707/diff/
> 
> 
> Testing
> -------
> 
> builds
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20160424/6b92e0c2/attachment.html>


More information about the kde-doc-english mailing list