[kde-doc-english] Review Request 122245: Adapt KWave docs and translations to Scripty's workflow

Mon Jan 26 04:58:41 UTC 2015

> On Jan. 25, 2015, 3:36 nachm., Pino Toscano wrote:
> > You don't need to move the English documentation from doc/en to doc, for making it work with Scripty...
> 
> Burkhard Lück wrote:
>     That's true, but I'd like to have a minimal numebers of exceptions from the policy "docbooks in /doc or /docs"
>     It makes applying changes to documentation_paths less error-prone.
> 
> Pino Toscano wrote:
>     Can you please point me where this policy is set?
>     
>     I don't see anything wrong with having English documentation under doc/en, and from some point of view also eases the release process a bit (doc/CMakeLists.txt can be totally autogenerated, for example).
>     This was done in the past by a couple of extragear, which have been changed from doc/en from doc for apparently no reason other than "others do this"...
> 
> Albert Astals Cid wrote:
>     "Others do this" is actually a very good reason. Uniformity makes it easier for everyone to understand what's going on.
> 
> Pino Toscano wrote:
>     I would agree if it were a totally different structure. This is **just** about a subdirectory more, which our tools already handle fine; furthermore, this is done by others already, even on git.k.o, so the "others do this" is valid **also** for what kwave does already.

Ok guys, there are a lot of things to change now, please give me some days!
(writing a Messages.sh, fixing the build system and so on...)

Regarding the doc/en directory: that one was also intended to hold images that are commonly used, for _all_ languages (e.g. those that contain no text), so please be careful when moving the files from there to their new location. All language dependent stuff follows the pattern "kwave-*.png", the rest is common. Is it okay to leave common stuff at this location?

- Thomas

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122245/#review74705
-----------------------------------------------------------

On Jan. 25, 2015, 2:29 nachm., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122245/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2015, 2:29 nachm.)
> 
> 
> Review request for Documentation, Localization and Translation (l10n), Thomas Eschenbacher, and Yuri Chornoivan.
> 
> 
> Repository: kwave
> 
> 
> Description
> -------
> 
> * delete all po files and localized screenshots, they will be imported into trunk/l10n-kde4 before this commit
> 
> * mv en docbookspngs to proper location in source
> 
> * adapt CMakeLists.txt
> 
> @ Thomas Eschenbacher:
> * I did not find a Messages.sh in the source tree, please add it
> * /CMakeLists.txt needs mor clean up wrt documentation and translation
> 
> 
> Diffs
> -----
> 
>   doc/audio2signal.png PRE-CREATION 
>   doc/cs/kwave-fileinfo.png e781989 
>   doc/cs/kwave-gui-mdi.png 5d723a9 
>   doc/cs/kwave-gui-sdi.png 58f124d 
>   doc/cs/kwave-gui-tab.png 4842f62 
>   doc/cs/kwave-lowpass.png 735b5f1 
>   doc/cs/kwave-main.png e5e0618 
>   doc/cs/kwave-memory-setup.png 5a2bd96 
>   doc/cs/kwave-newfile.png cf4e606 
>   doc/cs/kwave-notchfilter.png d036362 
>   doc/cs/kwave-pitch.png bbc2e90 
>   doc/cs/kwave-playback-setup.png 9785d93 
>   doc/cs/kwave-record.png 0c0930c 
>   doc/cs/kwave-sonagram-setup.png 18bc211 
>   doc/cs/kwave-sonagram.png 5579d1b 
>   doc/cs/kwave-volume.png 7762882 
>   doc/de/kwave-fileinfo.png 684e30b 
>   doc/de/kwave-gui-mdi.png a7602cc 
>   doc/de/kwave-gui-sdi.png 9658408 
>   doc/de/kwave-gui-tab.png b05f588 
>   doc/de/kwave-lowpass.png da1f4db 
>   doc/de/kwave-main.png b18705f 
>   doc/de/kwave-memory-setup.png 6c4f38e 
>   doc/de/kwave-newfile.png d50230c 
>   doc/de/kwave-notch-filter.png 65c0a68 
>   doc/de/kwave-pitch.png 940361d 
>   doc/de/kwave-playback-setup.png fc1bdc0 
>   doc/de/kwave-record.png ed3cfe1 
>   doc/de/kwave-sonagram-setup.png 1fbf81b 
>   doc/de/kwave-sonagram.png 6548733 
>   doc/de/kwave-volume.png 39950d0 
>   doc/en/audio-1.png e71261a 
>   doc/en/audio2signal.png 517293c 
>   doc/en/krec_record.png fa8c4d7 
>   doc/en/kwave-fileinfo.png c9135f0 
>   doc/en/kwave-gui-mdi.png 4b937a5 
>   doc/en/kwave-gui-sdi.png 4582548 
>   CMakeLists.txt 2497ac4 
>   doc/CMakeLists.txt a3a98c6 
>   doc/audio-1.png PRE-CREATION 
>   doc/en/kwave-memory-setup.png bbc8de9 
>   doc/en/kwave-newfile.png b87a865 
>   doc/en/kwave-notch-filter.png 6c7e286 
>   doc/en/kwave-pitch.png 94b3d2e 
>   doc/en/kwave-playback-setup.png 560a6a6 
>   doc/en/kwave-record.png 5d406a9 
>   doc/en/kwave-sonagram-setup.png c27405e 
>   doc/en/kwave-sonagram.png 1873be2 
>   doc/en/kwave-volume.png d854eef 
>   doc/en/light_off.png ddd370b 
>   doc/en/light_on.png 2ef9f36 
>   doc/en/nonlinear.png be88507 
>   doc/en/record_new.png 1e8857e 
>   doc/en/record_pause.png d1cb113 
>   doc/en/record_stop.png 4e87227 
>   doc/en/signal2digital.png b812967 
>   doc/en/signed.png 80034c8 
>   doc/en/sinus2samples.png e451557 
>   doc/en/under-construction.png 13dae2e 
>   doc/en/unsigned.png 7b2cc6c 
>   doc/es/kwave-fileinfo.png 79ab985 
>   doc/es/kwave-gui-mdi.png 526bfd8 
>   doc/es/kwave-gui-sdi.png 9dcf815 
>   doc/es/kwave-gui-tab.png 4047c50 
>   doc/es/kwave-lowpass.png a85bba5 
>   doc/es/kwave-main.png b5dbbbe 
>   doc/es/kwave-memory-setup.png 750cb33 
>   doc/es/kwave-newfile.png 7f01df8 
>   doc/es/kwave-notch-filter.png b75dfb5 
>   doc/es/kwave-pitch.png 11f754e 
>   doc/es/kwave-playback-setup.png f25d81b 
>   doc/es/kwave-record.png 348fa0e 
>   doc/es/kwave-sonagram-setup.png 2f5731d 
>   doc/es/kwave-sonagram.png b4c95ed 
>   doc/es/kwave-volume.png 4446720 
>   doc/fr/kwave-fileinfo.png 4582869 
>   doc/fr/kwave-lowpass.png 8dffc23 
>   doc/fr/kwave-main.png ddf1923 
>   doc/fr/kwave-memory-setup.png c2538f5 
>   doc/fr/kwave-newfile.png 4351994 
>   doc/fr/kwave-notch-filter.png a8ecb28 
>   doc/fr/kwave-pitch.png 07627f6 
>   doc/fr/kwave-playback-setup.png d3d8b6d 
>   doc/fr/kwave-record.png b656ea7 
>   doc/fr/kwave-sonagram-setup.png 1e72a79 
>   doc/fr/kwave-sonagram.png f57a8f4 
>   doc/fr/kwave-volume.png 372dade 
>   doc/help_cs.po 9b447e7 
>   doc/help_de.po c7d9957 
>   doc/help_en.docbook a6b9338 
>   doc/help_es.po c645cef 
>   doc/help_fr.po 468c1e3 
>   doc/index.docbook PRE-CREATION 
>   doc/krec_record.png PRE-CREATION 
>   doc/kwave-fileinfo.png PRE-CREATION 
>   doc/kwave-gui-mdi.png PRE-CREATION 
>   doc/kwave-gui-sdi.png PRE-CREATION 
>   doc/kwave-gui-tab.png PRE-CREATION 
>   doc/kwave-lowpass.png PRE-CREATION 
>   doc/kwave-main.png PRE-CREATION 
>   doc/kwave-memory-setup.png PRE-CREATION 
>   doc/kwave-newfile.png PRE-CREATION 
>   doc/kwave-notch-filter.png PRE-CREATION 
>   doc/kwave-pitch.png PRE-CREATION 
>   doc/kwave-playback-setup.png PRE-CREATION 
>   doc/kwave-record.png PRE-CREATION 
>   doc/kwave-sonagram-setup.png PRE-CREATION 
>   doc/kwave-sonagram.png PRE-CREATION 
>   doc/kwave-volume.png PRE-CREATION 
>   doc/light_off.png PRE-CREATION 
>   doc/light_on.png PRE-CREATION 
>   doc/nonlinear.png PRE-CREATION 
>   doc/record_new.png PRE-CREATION 
>   doc/record_pause.png PRE-CREATION 
>   doc/record_stop.png PRE-CREATION 
>   doc/signal2digital.png PRE-CREATION 
>   doc/signed.png PRE-CREATION 
>   doc/sinus2samples.png PRE-CREATION 
>   doc/under-construction.png PRE-CREATION 
>   doc/unsigned.png PRE-CREATION 
>   po/CMakeLists.txt d602567 
>   po/cs.po 7ed26a7 
>   po/de.po 474ea8a 
>   po/es.po 34684b5 
>   po/fr.po 770b47e 
>   po/kwave.pot d7f46f1 
>   doc/en/kwave-main.png 571f68f 
>   doc/en/kwave-gui-tab.png 423c215 
>   doc/en/kwave-lowpass.png 2bfd88f 
> 
> Diff: https://git.reviewboard.kde.org/r/122245/diff/
> 
> 
> Testing
> -------
> 
> builds and is properly translated
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20150126/f693c8bb/attachment.html>