[kde-doc-english] [trojita] src/Gui: GUI: Do not enable per-message actions on startup

Jan Kundrát jkt at kde.org
Tue Dec 1 09:59:16 UTC 2015


Git commit 9a5615adb9ef6b1a6174b273377a165cbdc5f192 by Jan Kundrát.
Committed on 30/11/2015 at 16:03.
Pushed by gerrit into branch 'master'.

GUI: Do not enable per-message actions on startup

...or on network reconnect. These actions all depend on the set of
selected messages. As a result of more or less non-specific slot
execution order, the GUI items were inadvertently enabled even though no
messages were actually selected.

BUG: 354760
Change-Id: I0b5ce16e93c8ca431b5a6853ea4d30927b43007a

M  +1    -5    src/Gui/Window.cpp

http://commits.kde.org/trojita/9a5615adb9ef6b1a6174b273377a165cbdc5f192

diff --git a/src/Gui/Window.cpp b/src/Gui/Window.cpp
index cf54358..8577f70 100644
--- a/src/Gui/Window.cpp
+++ b/src/Gui/Window.cpp
@@ -1535,11 +1535,7 @@ void MainWindow::updateActionsOnlineOffline(bool online)
     createTopMailbox->setEnabled(online);
     deleteCurrentMailbox->setEnabled(online);
     m_actionMarkMailboxAsRead->setEnabled(online);
-    markAsDeleted->setEnabled(online);
-    markAsRead->setEnabled(online);
-    markAsFlagged->setEnabled(online);
-    markAsJunk->setEnabled(online);
-    markAsNotJunk->setEnabled(online);
+    updateMessageFlags();
     showImapCapabilities->setEnabled(online);
     if (!online) {
         m_replyGuess->setEnabled(false);


More information about the kde-doc-english mailing list