[kde-doc-english] Review Request 124341: Add docbook for kwineffects kcm

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124341/#review83806
-----------------------------------------------------------


sorry for the late reply.

Overall the documentation sounds good and correct, just one comment for the filter of effects.


doc/kwineffects/index.docbook (lines 38 - 44)
<https://git.reviewboard.kde.org/r/124341/#comment58034>

    isn't this a bit too technical? I mean especially words like "OpenGL", "XRender", "KWin Core" (what is KWin?) "compositing backend"
    
    Maybe also move the block to further down. The idea from software side was to hide the "useless" effects as users don't need to interact with them. Having them exposed so prominently in the help module might work against that.
    
    Concerning KWin Core effects: these are effects which are controlled by other config modules. This is something which might make sense to be mentioned (an example is window geometry which is bound to the setting in a different KCM).


- Martin Gräßlin


On July 13, 2015, 9:46 p.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124341/
> -----------------------------------------------------------
> 
> (Updated July 13, 2015, 9:46 p.m.)
> 
> 
> Review request for Documentation and Martin Gräßlin.
> 
> 
> Repository: kwin
> 
> 
> Description
> -------
> 
> I used a lot of infos from Martins blog, many thanks
> 
> http://blog.martin-graesslin.com/blog/2014/03/desktop-effects-control-module-in-kwin5/
> 
> A small part is a copy from kwincompositing docbook
> 
> 
> Diffs
> -----
> 
>   doc/CMakeLists.txt 2768884 
>   doc/kwineffects/CMakeLists.txt PRE-CREATION 
>   doc/kwineffects/configure-effects.png PRE-CREATION 
>   doc/kwineffects/configure-filter.png PRE-CREATION 
>   doc/kwineffects/dialog-information.png PRE-CREATION 
>   doc/kwineffects/index.docbook PRE-CREATION 
>   doc/kwineffects/video.png PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124341/diff/
> 
> 
> Testing
> -------
> 
> builds
> 
> 
> File Attachments
> ----------------
> 
> What is the meaning of these buttons?
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/13/7f2ae492-482e-4ccc-8f77-29fe06ba487d__strange-buttons.png
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20150814/adfca2e2/attachment.html>