[kde-doc-english] Review Request 111917: Corrected the text from the context menu of pasting an URL in the Kmail composer

[Scarlett Clark]

> On Dec. 9, 2013, 11:56 a.m., Burkhard Lück wrote:
> > Sorry for the delay, please commits.
> > Thanks.
> 
> Scarlett Clark wrote:
>     I noticed this never got committed. What is the story? It would be nice to have it in.
> 
> Burkhard Lück wrote:
>     In 4.12 it was changed as suggested:
>     const QAction *addAsTextAction = p.addAction( i18np("Add URL into Message as &Text", "Add URLs into Message as &Text", urlList.size() ) );
>     but master now has 
>     const QAction *addAsTextAction = p.addAction( i18np("Add URL into Message", "Add URLs into Message", urlList.size() ) );
> 
> Albert Astals Cid wrote:
>     Which i guess is also good, no?
>     
>     I'll mark this thing as commited. Please tell me if it is not.
> 
> Scarlett Clark wrote:
>     Actually I think master now has the original confusing text. Aka when you paste in a composed email "Add URLs into Message" leads you to believe a clickable url will be pasted in, that is not the case, only text is pasted. Hence the change, which apparently got in somehow, and then removed. Not sure what happened here.
> 
> Albert Astals Cid wrote:
>     I don't see why you'd believe it's clickable, a url is not something that's clickable per se, it's just in a protocol://host/path/bla format, the fact that is clickable or not totally depends on the application rendering that, i.e. the thing you have in the url bar of your browser, is an url, and it's not clickable at all.

Confirmed. The clickable (link) Url is dependent on the viewer (tested with kmail -> thunderbird). Unless Ovidiu-Florin Bogdan responds with a reason to need a clickable url within composer, I say leave this closed.


- Scarlett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/111917/#review45429
-----------------------------------------------------------


On Sept. 24, 2014, 12:58 p.m., Ovidiu-Florin Bogdan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/111917/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2014, 12:58 p.m.)
> 
> 
> Review request for Documentation and KDEPIM.
> 
> 
> Bugs: 323246
>     http://bugs.kde.org/show_bug.cgi?id=323246
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> This function name is confusing as it leads the user to believe that the URL being pasted in the message is pasted as a URL, so I've renamed it to "Add URL into Message as Text"
> 
> 
> Diffs
> -----
> 
>   kmail/editor/kmcomposewin.cpp eee96e5 
> 
> Diff: https://git.reviewboard.kde.org/r/111917/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ovidiu-Florin Bogdan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20140924/903bd3e1/attachment.html>