[kde-doc-english] Review Request 116786: Make error handling more consistent and fail earlier

Luigi Toscano luigi.toscano at tiscali.it
Thu Mar 13 20:57:58 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116786/#review52907
-----------------------------------------------------------



src/meinproc.cpp
<https://git.reviewboard.kde.org/r/116786/#comment37240>

    Please save the value of tss before the call, otherwise it will be always empty


- Luigi Toscano


On March 13, 2014, 5:39 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116786/
> -----------------------------------------------------------
> 
> (Updated March 13, 2014, 5:39 p.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> -------
> 
> This should makes it easier to interpret future failures, for example by not running xmllint if catalogs are missing.
> 
> 
> Diffs
> -----
> 
>   src/meinproc.cpp 22150ab 
> 
> Diff: https://git.reviewboard.kde.org/r/116786/diff/
> 
> 
> Testing
> -------
> 
> Clean-rebuilt all frameworks which depends on kdoctools, plus kde-runtime, kde-workspace, konsole, kate.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20140313/fde3fedd/attachment.html>


More information about the kde-doc-english mailing list