[kde-doc-english] Review Request 115896: Import FindDocBook*.cmake from extra-cmake-modules

[Alex Merry]

> On Feb. 19, 2014, 12:52 p.m., Luigi Toscano wrote:
> > Sorry for the low cmake-fu, but does that change in CMakeLists.txt mean that they are going to exported?

No, it's just to allow CMake to find them when it's configuring kdoctools.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115896/#review50219
-----------------------------------------------------------


On Feb. 19, 2014, 12:47 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115896/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2014, 12:47 p.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> -------
> 
> Commits imported with `git format-patch` (edited), followed by `git am`.
> 
> 
> Add the local cmake directory to the CMake module path
> 
> 
> Use the newer syntax in FindDocBook*
> 
> It approprietly sets the _FOUND variables, we were defining the all
> uppercase instead.
> Sorry for the mess!
> 
> Originally commit 190c79bb4e6bc8b8757bd890485a9bafb4a65219 of the
> extra-cmake-modules repository
> 
> Move FindDocBook* to find-modules
> 
> Originally commit d42d5889d25ac4c900a294f283dd802eccf96010 of the
> extra-cmake-modules repository
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d135e0caa55d126ba3c335b9f05f8125453c1e53 
>   cmake/FindDocBookXML.cmake PRE-CREATION 
>   cmake/FindDocBookXSL.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115896/diff/
> 
> 
> Testing
> -------
> 
> Removed FindDocBook*.cmake from $PREFIX/share/ECM/find-modules, and a clean configure, build, install still works.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20140219/fcf55c39/attachment.html>