[kde-doc-english] Review Request 115708: Build on Mac OS X

[Luigi Toscano]

> On Feb. 12, 2014, 9:48 p.m., Harald Fernengel wrote:
> > src/CMakeLists.txt, line 149
> > <https://git.reviewboard.kde.org/r/115708/diff/1/?file=243799#file243799line149>
> >
> >     Note - cmake is documented to replace the COMMAND by the actual command, as we added it with "add_executable" before. Still, I would like someone to test this on non Mac OS X platforms :)

Before submitting this, could you please test this review?

https://git.reviewboard.kde.org/r/115209

Because it fixes this and other stuff.


- Luigi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115708/#review49680
-----------------------------------------------------------


On Feb. 12, 2014, 9:46 p.m., Harald Fernengel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115708/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2014, 9:46 p.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> -------
> 
> On Mac OS X, the binary is in docbookl10nhelper.app/..., so let cmake substitute the actual binary instead of hard-coding it. Should also fix the build on windows, where the executable has a .exe suffix
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 5c824941359a68eb8dc54836d05db1fdb217bf6a 
> 
> Diff: https://git.reviewboard.kde.org/r/115708/diff/
> 
> 
> Testing
> -------
> 
> Building on Mac OS X
> 
> 
> Thanks,
> 
> Harald Fernengel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20140212/02748d63/attachment.html>