[kde-doc-english] [trojita] src/Gui: GUI: hide the FindBar when the underlying QWebView disappears

Jan Kundrát jkt at flaska.net
Mon Mar 11 17:50:48 UTC 2013


Git commit 90a86e8c9ecf497d01984cc7da00ae2d97f7e1db by Jan Kundrát.
Committed on 11/03/2013 at 18:47.
Pushed by jkt into branch 'master'.

GUI: hide the FindBar when the underlying QWebView disappears

Looks like there were enough checks in place :), but in the form of asserts :(.
It's cleaner to just dismiss the search widget when the web view disappears.

M  +5    -0    src/Gui/FindBar.cpp

http://commits.kde.org/trojita/90a86e8c9ecf497d01984cc7da00ae2d97f7e1db

diff --git a/src/Gui/FindBar.cpp b/src/Gui/FindBar.cpp
index bc3e771..fb6fc60 100644
--- a/src/Gui/FindBar.cpp
+++ b/src/Gui/FindBar.cpp
@@ -263,7 +263,12 @@ void FindBar::updateHighlight()
 
 void FindBar::setAssociatedWebView(QWebView *webView)
 {
+    if (m_associatedWebView)
+        disconnect(m_associatedWebView, 0, this, 0);
     m_associatedWebView = webView;
+
+    // Automatically hide this FindBar widget when the underlying webview goes away
+    connect(m_associatedWebView, SIGNAL(destroyed(QObject*)), this, SLOT(hide()));
 }
 
 }


More information about the kde-doc-english mailing list