[kde-doc-english] Review Request 111248: Documentation: Rework of menus.docbook Phase One. EBN Fixes.

[Scarlett Clark]

> On June 26, 2013, 4:27 p.m., Burkhard Lück wrote:
> > doc/kmail/menus.docbook, line 1433
> > <http://git.reviewboard.kde.org/r/111248/diff/3/?file=165911#file165911line1433>
> >
> >     We are going to replace all common items from settings menu with a link to fundamentals, same for the help menu, leaving only the application specific items - if any.
> >     
> >     An example how this is done you find in
> >     http://docs.kde.org/development/en/kdeedu/kgeography/commands.html#idp7394256

Why is this even here???? I did not touch this section. Unless it was an EBN fix.


> On June 26, 2013, 4:27 p.m., Burkhard Lück wrote:
> > doc/kmail/menus.docbook, line 57
> > <http://git.reviewboard.kde.org/r/111248/diff/3/?file=165911#file165911line57>
> >
> >     According to 
> >     http://lists.kde.org/?l=kde-doc-english&m=136785862821426&w=2
> >     and
> >     http://lists.kde.org/?l=kde-doc-english&m=137189575801434&w=2
> >     
> >     there should be no >gui...> markup in title elements (no one objected so far)

I will have to remove those from the entire document then.


> On June 26, 2013, 4:27 p.m., Burkhard Lück wrote:
> > doc/kmail/menus.docbook, lines 165-170
> > <http://git.reviewboard.kde.org/r/111248/diff/3/?file=165911#file165911line165>
> >
> >     /me has this item in recent master

Not on mine built by kdesrc-build. Clearly not working then, I have tried to figure out how to properly have a dev build with no success. sigh.


> On June 26, 2013, 4:27 p.m., Burkhard Lück wrote:
> > doc/kmail/menus.docbook, lines 264-266
> > <http://git.reviewboard.kde.org/r/111248/diff/3/?file=165911#file165911line264>
> >
> >     Don#t have that item here

Again, I seem to have the wrong build.


> On June 26, 2013, 4:27 p.m., Burkhard Lück wrote:
> > doc/kmail/menus.docbook, line 157
> > <http://git.reviewboard.kde.org/r/111248/diff/3/?file=165911#file165911line157>
> >
> >     default format is <filename class="extension">.mbox</filename>
> >     use case? import singe message with all info into another mailer?

I don't understand this at all, no where in this file has there been use cases. I think use cases are more appropriate in the actual user manual rather than here.


> On June 26, 2013, 4:27 p.m., Burkhard Lück wrote:
> > doc/kmail/menus.docbook, line 138
> > <http://git.reviewboard.kde.org/r/111248/diff/3/?file=165911#file165911line138>
> >
> >     technically the new contact dialog is from a library in kdepimlibs afaik; an is used by many applications (kgpp, kmail, kontact, kadressbook etc.) so it does not really make sense to use the application &contact; here, please remove it.

ok. will fix


> On June 26, 2013, 4:27 p.m., Burkhard Lück wrote:
> > doc/kmail/menus.docbook, line 110
> > <http://git.reviewboard.kde.org/r/111248/diff/3/?file=165911#file165911line110>
> >
> >     "(no templates)" is a guimenuitem, right?

ok. will fix


> On June 26, 2013, 4:27 p.m., Burkhard Lück wrote:
> > doc/kmail/menus.docbook, line 231
> > <http://git.reviewboard.kde.org/r/111248/diff/3/?file=165911#file165911line231>
> >
> >     string is ""Update These Folders and All Their Subfolders" here
> >

Mine is actually These = This, but it is possible my build is wrong..


- Scarlett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111248/#review35128
-----------------------------------------------------------


On June 26, 2013, 3:32 p.m., Scarlett Clark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111248/
> -----------------------------------------------------------
> 
> (Updated June 26, 2013, 3:32 p.m.)
> 
> 
> Review request for Documentation, KDEPIM and Laurent Montel.
> 
> 
> Description
> -------
> 
> Reworking menus.docbook to match current menus. I am rewriting one section at a time due to size of this endeavor. EBN fixes apply to entire document.
> 
> 
> Diffs
> -----
> 
>   doc/kmail/menus.docbook e8298c4 
> 
> Diff: http://git.reviewboard.kde.org/r/111248/diff/
> 
> 
> Testing
> -------
> 
> checkXML index.docbook (after every change!) meinproc4 index.docbook, konqueror index.docbook. EBN.
> 
> 
> Thanks,
> 
> Scarlett Clark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20130626/d396d5dc/attachment-0001.html>