[kde-doc-english] Patch for Okular documentation and a question

[Antoni Bella Pérez]

El Diumenge, 9 de setembre de 2012, a les 14:40:57, Burkhard Lück va escriure:
> Am Samstag, 8. September 2012 19:35:03 schrieb Yuri Chornoivan:
> > Hi!
> > 
> > написане Sat, 08 Sep 2012 20:17:20 +0300, Antoni Bella Pérez
> > 
> > <antonibella5 at orange.es>:
> > >   Hi
> > > 
> > >   Fix highlighting of two shortcuts:
> > > --- okular/index.docbook.old    2012-09-08 18:28:18.000000000 +0200
> > > +++ okular/index.docbook        2012-09-08 19:07:05.764570093 +0200
> > > @@ -139,2 +139,2 @@
> > > -                       Start automatic scrolling with <keycombo
> > > action="simul">&Shift;<keysym>Down Arrow</keysym></keycombo> or
> > > -                       <keycombo action="simul">&Shift;<keysym>Up
> > > Arrow</keysym></keycombo>. Then use these keys to increase and
> > > +                       Start automatic scrolling with <keycombo
> > > action="simul">&Shift;<keycap>Down Arrow</keycap></keycombo> or
> > > +                       <keycombo action="simul">&Shift;<keycap>Up
> > > Arrow</keycap></keycombo>. Then use these keys to increase and
> > 
> > Thanks for the patch. Technically this is not correct as Primer says:
> > 
> > http://techbase.kde.org/Documentation_Primer/Manual/DocBook_Reference/GUI_
> > e
> > lements
> > 
> > "<keysym>
> > Right arrow is the <keysym> for the <keycap> that looks like ->. Please
> > note this is a KDE specific use of <keysym>, and does not precisely follow
> > the examples in the Duck Book."
> > 
> > So this patch will be applied only after Burkhard's confirmation. ;)
> 
> I aggree with Antoni that having "Down Arrow" on one page like
> http://docs.kde.org/stable/en/kdegraphics/okular/navigating.html once with
> and once without highlighting is wrong.
> 
> But we have 179 markup using "keysym" in all docbooks, that should be fixed
> as well.
> That can be done with this patch for kde-docs.css:
> 
> ~/svn/kdelibs(KDE/4.9)$ git diff
> diff --git a/doc/common/kde-docs.css b/doc/common/kde-docs.css
> index a892891..12291a4 100644
> --- a/doc/common/kde-docs.css
> +++ b/doc/common/kde-docs.css
> @@ -195,7 +195,7 @@ div.sect2 {
>      border-radius: 2px;
>  }
> 
> -.keycap {
> +.keycap, .keysym {
>      background-color: #DFDFFF;
>      font-weight: bold;
> 
> That is my preferred solution

  Hi Burkhard

  Yes. It is the best solution.

  Toni