RFC: Enabling -Wshadow, by default?

[Thomas Baumgart]

On Montag, 5. Januar 2026 19:29:17 CET Christoph Grüninger wrote:

> Hi Friedrich,
> I often resolve compiler warnings and findings from static analyzers. 
> Last year I spotted a real bug where shadowing mislead the original 
> author to use the wrong variable. I could not find the according pull 
> request, I think it was outside of KDE.

We had a shadowing problem causing a misbehavior in KMyMoney, but same here:
I don't find it anymore w/o investing more time than I have available.

> Personally, I consider shadowing a defect and I would not accept it in a 
> review.

+1

-- 

Regards

Thomas Baumgart

-------------------------------------------------------------
My software never has bugs.
It just develops random features ... -- anonymous
-------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 868 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-devel/attachments/20260106/fcf1a5ad/attachment.sig>