Changing dependencies for a project

[Johnny Jazeix]

Hi,

To paraphrase Captain Tsubasa "the CI is your friend". If there was a
merge request, the build would have failed and you still would have
sent a mail here to ask how to add the dependency :). Even for smaller
changes, it's always interesting to have the CI run because it's quite
quick and can find small issues that can be avoided (for example, if a
file is added, it could be easy to miss to add the licence, the reuse
job will fail and in a wonderful world, the commit where the file has
been added would be amended to add the licence and we will have a
clean history. Or if a xml is not correctly formatted for example).

Heiko answered you for the process to add the dependency. And thanks
for the change, it's always nice to have up-to-date code!

Cheers,

Johnny


Le mer. 10 juil. 2024 à 01:52, David Jarvie <djarvie at kde.org> a écrit :
>
> On Tuesday, 9 July 2024 23:47:30 BST Albert Astals Cid wrote:
> > El dimarts, 9 de juliol del 2024, a les 22:12:40 (CEST), David Jarvie va
> >
> > escriure:
> > > I have just changed the dependencies for KAlarm (removed Canberra, added
> > > libvlc and libvlccore), but after committing the changes, the build fails
> > > on invent.kde.org.
> >
> > In the future probably helps if you do similar (or all) your changes as
> > Merge Requests instead of directly committing.
> >
> > This way you would have found this issue earlier and we would not end up
> > with a non compiling CI.
>
> If I'd created a merge request, it would presumably have just sat there
> unmergeable because of the missing CI dependency. How does a new dependency
> get added to the CI?
>
> > > I've changed everything I can find in the KAlarm repository
> > > relating to the dependencies, so is there something else I need to do to
> > > set up the new dependencies?
>
> --
> David Jarvie.
> KDE developer, KAlarm author.