MR Gardening - A discussion, please leave your input!

[Ben Cooksley]

On Sat, Mar 11, 2023 at 3:19 AM David Hurka <david.hurka at mailbox.org> wrote:

> On Thursday, March 9, 2023 9:40:47 AM CET Méven wrote:
> > We could use a "stale" label for MR to allow maintainers to see the
> > script's results.
> > And even a "closing-soon" label, for MR not-update in the last 12 months.
>
> Is there a rule that all open merge requests need care?
> I would expect that it is enough to label an open merge request as “stale”.
>
> Merge requests are usually closed because they are bad.
> Stale merge requests are probably good, otherwise they would have been
> closed
> intentionally.
>

I recall in the last few months someone mentioning a MR in #kde-devel that
had been approved and just never merged, and had been sitting like that for
months.
All it took to get merged was a reminder by way of comment on the MR to get
it merged as the original author of the change was no longer around.

So yes, there is definitely value in reminders and caring for those MRs.

I guess the difference here is between higher activity projects - whose MRs
are likely to be more well looked after - and those with lower activity.
Projects with lower activity tend to involve developers who look after many
different projects, and will therefore benefit from reminders. Those with
higher activity are much less likely to see value from it.

Closing of MRs though is something that should only be done after review by
the developers who run the project.


>
> David
>
>
>
Regards,
Ben
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-devel/attachments/20230311/9deb4706/attachment.htm>