Starting with KDE Development + tests issue

[Albert Astals Cid]

El divendres, 9 d’abril de 2021, a les 18:04:56 (CEST), Chinmoy Pradhan va escriure:
> Hello Stefano,
> 
> I'd suggest going ahead with the merge request. Make sure your changes
> aren't directly or indirectly responsible for the failing tests beforehand.
> (IIRC there aren't any tests for the recent file list.)
> Also a separate merge request fixing the failing autotests would be nice.

The Okular unit tests don't fail though, so there's something wrong with your setup, please check that before spending time fixing something that's not broken.

Cheers,
  Albert

P.S: Well to be exact there was 1 broken tonight, but not 19.

> 
> Regards,
> Chinmoy
> 
> On Fri, Apr 9, 2021 at 8:55 PM Stefano <sqrtstefano at gmail.com> wrote:
> 
> > Hi!
> >
> > I would like to start contributing to KDE. A few days ago I submitted a
> > bug report for the Okular project (here: <
> > https://bugs.kde.org/show_bug.cgi?id=435075>). As I didn't receive any
> > feedback there, and as I had a feeling it was an easy fix, I tried working
> > on it (and it's indeed a few-lines fix).
> >
> > According to the guidelines I found here<
> > https://community.kde.org/Get_Involved/development#Test_your_changes>, at
> > this point I should make sure that all unit tests pass before actually
> > trying to submit anything, but I encountered a problem I'm not sure how to
> > deal with: even on the repository code as-is many (19 out of 26) tests
> > fail. So I'm not really sure how to proceed at this point. Should I just
> > submit the merge request? Should I open a bug report for the test suite?
> >
> > Best,
> > Stefano
> >
>