KDiagram - Persistent FTBFS for stable branch on Windows

[Johnny Jazeix]

Hi,

issue is there:
https://invent.kde.org/graphics/kdiagram/-/blob/2.7/src/KChart/CMakeLists.txt#L126
qt5_wrap_cpp(KChart kchart_LIB_SRCS KChartEnums.h) should be
qt5_wrap_cpp(kchart_LIB_SRCS KChartEnums.h)

I'm fixing it.

Johnny


Le lun. 12 oct. 2020 à 16:32, Milian Wolff <mail at milianw.de> a écrit :

> On Montag, 12. Oktober 2020 14:04:06 CEST Dag wrote:
> > mandag den 12. oktober 2020 12.58.36 CEST skrev Dag:
> > > mandag den 12. oktober 2020 12.04.04 CEST skrev Milian Wolff:
> > >> On Montag, 12. Oktober 2020 11:28:45 CEST Ben Cooksley wrote:
> > >>> On Mon, Oct 12, 2020 at 10:24 PM Milian Wolff
> > >>> <mail at milianw.de> wrote: ...
> > >>
> > >> Thanks, but that's looking worse then I expected. I guess
> > >> backporting `35e86e964908ee906dde4f0678c16a838e4712dd` is worth
> > >> a shot.
> > >>
> > >> @Dag: what do you say, should that be safe enough to do?
> > >
> > > No, it will not apply cleanly. I'll do it.
> >
> > Done, but made no difference, still fails.
> > Also tried qt_wrap_cpp -> qt5_wrap_cpp w/o sucess.
> >
> > I'm clueless on windows and can't run any virtual on my machine.
> >
> > Afaics we have this situation, please comment if wrong:
> > - The windows build worked earlier, prior to move to invent.
> > - There has been no changes to the stable branch between the successful
> > build and the failed build.
> > - At the first failing build of stable (oct 6), the code that seems to
> > trigger the failure was the same in stable and unstable except for the
> > qt5_wrap_cpp.
> > - There has been some modernization of unstable, mostly Q_FOREACH() ->
> > for()
> >
> > I'm at loss of even where to start to look, so I hope somebody can point
> a
> > finger in the right direction.
>
> Try to add a src/KChart/KChartEnums.cpp file - I actually wonder how this
> compiles at all on non-windows platforms :)
>
> Also add this line to the .h:
>
> ```
> ~KChartEnums();
> ```
>
> and then this in the .cpp:
>
> ```
> #include "KChartEnums.h"
>
> KChartEnums::~KChartEnums() = default;
> ```
>
> This should ensure that moc knows where to put the include for the
> generated
> code (into KChartEnums.cpp).
>
> Cheers
> --
> Milian Wolff
> mail at milianw.de
> http://milianw.de
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-devel/attachments/20201012/cd078df8/attachment.htm>