[PATCH] qwidget_win.cpp - setIcon support

Jeremy C. Andrus jeremy at jeremya.com
Tue Dec 7 17:37:35 CET 2004


Hello,

I have just started using Qt, and really appreciate all the work that's
being done to port the X11 code to the native Win32 API. I recently
downloaded, compiled and used the QT_WIN32_3_3_BRANCH from CVS and was
extremely impressed! 

I found a couple of minor annoyances that didn't take too long to
fix-up. One of them was the 'setIcon' handling in the QWidget class. I
am one for a nice-looking GUI (one of the many reasons I started using
Qt), and the lack of a nice icon in the corner bugged me :-). This patch
works on my system (I built the code using MSVC.NET), and I hope that it
can be used elsewhere.

The other issue I ran into was that the .NET compiler is very picky
about comments in the Makefile. It doesn't like whitespace before the
'#' symbol, so I had to run  through the generated Makefile and fix
that. I wasn't sure how to submit a patch for that, so I thought that I
would just describe it. The vi regexp: 

        :%s/^\s*#/#/

fixed everything :-). Hope that helps!

Keep up the great work,

        -Jeremy


P.S. I'm not subscribed to this list, so please send me a personal reply
if you need anything else or something wasn't quite clear.

-- 
------------------------
Jeremy C. Andrus
http://www.jeremya.com/
------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: qwidget_win-setIcon.patch
Type: application/octet-stream
Size: 1691 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-cygwin/attachments/20041207/c6e85ffc/qwidget_win-setIcon.obj


More information about the kde-cygwin mailing list