KDE review request: KDominate
Akseli Lahtinen
akselmo at akselmo.dev
Thu Mar 26 18:34:16 GMT 2026
On Thursday 26 March 2026 18:31:55 Eastern European Standard Time Albert Vaca Cintora wrote:
> The following checkboxes still need ticking :)
>
> - A screenshot in product-screenshots
> - A bugs.kde.org product (file a sysadmin ticket)
>
> These two are done (but I think I shouldn't tick the boxes myself, right?).
>
> - Check the code with some sanity tools like clazy or clang-tidy, if not
> already done as part of CI runs
>
> Not automated in the CI but I ran clazy a few times during development and
> fixed the findings.
>
> - Passing KDE neon build
>
> No idea what needs to be done here.
>
> https://invent.kde.org/games/kdominate/-/issues/1
>
>
> On Sun, Mar 1, 2026 at 2:31 AM Albert Vaca Cintora <albertvaka at gmail.com>
> wrote:
>
> > The repo has now been moved to https://invent.kde.org/games/kdominate so
> > the review can proceed.
> >
> > On Fri, Feb 27, 2026 at 9:20 PM Albert Vaca Cintora <albertvaka at gmail.com>
> > wrote:
> >
> >> Hi,
> >>
> >> I wrote KDominate, a simple desktop game that I would like to make part
> >> of KDE Games.
> >>
> >> I reused the UI from KJumpingCube to keep the same look and feel as other
> >> KDE Games, although I modernized the code a bit (KJumpingCube was made in
> >> 1999!). The README explains both how to play and how the code is
> >> structured, so it might be useful to read.
> >>
> >> The gameplay is actually based on a shareware game for Windows 3.1 that I
> >> was nostalgic about, maybe someone here even played the original :)
> >>
> >> * Source: https://invent.kde.org/albertvaka/kdominate
> >> * Review checklist:
> >> https://invent.kde.org/albertvaka/kdominate/-/issues/1
> >>
> >> Albert
> >>
> >>
> >>
>
Just as an aside, some screenshots/videos in the readme could be nice :)
Best regards,
- Akseli
More information about the kde-core-devel
mailing list