KDE review request: KDominate
Albert Vaca Cintora
albertvaka at gmail.com
Tue Apr 7 15:19:55 BST 2026
🥳 What are the next steps, now? The wiki mentions the case where the
project is not accepted (*After two months in KDE Review the repo should be
moved back to playground or moved to unmaintained*) but says nothing about
the case the project is accepted.
On Mon, Apr 6, 2026 at 4:13 PM Albert Astals Cid <aacid at kde.org> wrote:
> El dijous, 26 de març del 2026, a les 17:31:55 (Hora d’estiu d’Europa
> central), Albert Vaca Cintora va escriure:
> > The following checkboxes still need ticking :)
> >
> > - A screenshot in product-screenshots
> > - A bugs.kde.org product (file a sysadmin ticket)
> >
> > These two are done (but I think I shouldn't tick the boxes myself,
> right?).
>
> For the ones that are factual, i think you can. Either there is or there
> is
> not a screenshot/product. I have done it for you anyway.
>
> >
> > - Check the code with some sanity tools like clazy or clang-tidy, if not
> > already done as part of CI runs
> >
> > Not automated in the CI but I ran clazy a few times during development
> and
> > fixed the findings.
>
> I also checked this one.
>
> >
> > - Passing KDE neon build
> >
> > No idea what needs to be done here.
> >
> > https://invent.kde.org/games/kdominate/-/issues/1
>
> Everything is checked now.
>
> Cheers,
> Albert
>
>
> >
> > On Sun, Mar 1, 2026 at 2:31 AM Albert Vaca Cintora <albertvaka at gmail.com
> >
> >
> > wrote:
> > > The repo has now been moved to https://invent.kde.org/games/kdominate
> so
> > > the review can proceed.
> > >
> > > On Fri, Feb 27, 2026 at 9:20 PM Albert Vaca Cintora <
> albertvaka at gmail.com>
> > >
> > > wrote:
> > >> Hi,
> > >>
> > >> I wrote KDominate, a simple desktop game that I would like to make
> part
> > >> of KDE Games.
> > >>
> > >> I reused the UI from KJumpingCube to keep the same look and feel as
> other
> > >> KDE Games, although I modernized the code a bit (KJumpingCube was
> made in
> > >> 1999!). The README explains both how to play and how the code is
> > >> structured, so it might be useful to read.
> > >>
> > >> The gameplay is actually based on a shareware game for Windows 3.1
> that I
> > >> was nostalgic about, maybe someone here even played the original :)
> > >>
> > >> * Source: https://invent.kde.org/albertvaka/kdominate
> > >> * Review checklist:
> > >> https://invent.kde.org/albertvaka/kdominate/-/issues/1
> > >>
> > >> Albert
>
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20260407/0751d9df/attachment.htm>
More information about the kde-core-devel
mailing list