KDE Review request: md4qt
Sune Vuorela
nospam at vuorela.dk
Mon Nov 4 07:44:58 GMT 2024
On 2024-11-01, Carl Schwan <carl at carlschwan.eu> wrote:
> This is a KDE Review request for md4qt. md4qt is a Markdown parser
> for Qt projects.
Where do you expect it to 'land' ? Frameworks? apps/libraries?
What api compatibilities are expected?
What does it do that Qt's markdown support in QTD doesn't do?
Which markdown variant(s) are supported?
I'm a bit surprised that it is a Qt library but uses a uncommon test
library.
What kind of fuzz-testing has this library for parsing user or network
provided data been involved in?
How does one get a QTextDocument out of this?
CMake uses GLOB_RECURSE. That's usually a bad sign.
The amount of shared_ptr in use for what's basically a dataparser is a
bit worrying to me.
On a more 'matter of taste'-note, it does look like someone has went
overboard with templates. While I like and understand templates,
/Sune
More information about the kde-core-devel
mailing list