New repo in kdereview: kclock

[Devin]

Hi everyone,

Is there any feedback left for KClock? If not, I will consider it to
have passed kdereview.

Thanks,
Devin

On Fri, Dec 30, 2022 at 2:27 AM Justin <justin.zobel at gmail.com> wrote:
>
> Thanks for the quick reply Albert. I'm not a developer but I've gone
> over much of the comments from previous:
>
> Tested on 22.11
>
>  > New Timer doesn't work? Ah it's because it needs kclockd running for
> that, would it be very hard to give a warning if it isn't running?
>
> Seems kclockd is now running automatically. If it is not automatically
> running that would (in my opinion) be a packaging issue on the distro side.
>
>  > Is that kirigamiaddons thing released? Seems to be the reason i can't
> add new Alarms
>
> Kirigami Addons has now passed KDE review and has stable releases
>
>  > Not an expert in UI but for stopwatch having Start/Pause on the top
> left feels a bit unnatural, maybe would make sense swapping reset and
> Start? Ask the VDG i guess.
>
> In the version I'm running it's centered nicely and I think works well.
> If you can check this against latest git master to confirm the UI is
> still the same.
>
>  > Also in stopwatch for me it'd make a lot of sense if pressing the
> time starts/pauses, what do you think?
>
> This is functioning now.
>
>  > Silence Alarm After shows an horizontal scrollbar that doesn't to be
> very useful https://i.imgur.com/7O8DBJc.png
>
> This is now called Ring Duration and has no horizontal scroll bar even
> at the minimum window width.
>
>  > It's even worse in Alarm Snooze Length where it goes over existing text
>
> Same as above, now fixed.
>
>  > You're missing Messages.sh in kclockd
>
> I see this now in the kclockd folder
>
>  > Please check i18n in your qml files, these seem like need i18n
>  > ...
>
> Lots of this i18n stuff appears to have been moved and will need a new
> review
>
>
> Justin
>
> On 30/12/22 20:44, Albert Astals Cid wrote:
> > El divendres, 30 de desembre de 2022, a les 8:46:56 (CET), Justin va escriure:
> >> Hey Team,
> >>
> >> This was last posted about on October 18 2021. I looked at the three
> >> items that were needed for kirigami-addons:
> >>
> >> * Missing is REUSE compliance:
> >> https://invent.kde.org/libraries/kirigami-addons/-/merge_requests/13
> >> * Hanyoung is working on a better time picker:
> >> https://invent.kde.org/libraries/kirigami-addons/-/merge_requests/17
> >> * And Clau is working on a better date picker:
> >> https://invent.kde.org/libraries/kirigami-addons/-/merge_requests/20
> >>
> >> They have all now been merged. Can we resume the review on
> >> kirigami-addons so we can continue on kclock?
> >>
> >> Thanks everyone and have a enjoyable and safe holiday!
> > I gave a long list of comments back in the day that were never answered, do
> > that first and maybe i give it another look.
> >
> > Cheers,
> >    Albert
> >
> >> Justin
> >
> >
> >