Review of Codevis (ie - Making Codevis a KDE Project)

[Tomaz Canabrava]

Update, now it works on windows and FreeBSD.
<3

On Tue, 22 Aug 2023 at 21:21 Tomaz Canabrava <tcanabrava at kde.org> wrote:

> Update, it now builds on qt6 and qt5.
> Struggling a bit with craft for windows.
>
>
> On Fri, 18 Aug 2023 at 21:22 Ben Cooksley <bcooksley at kde.org> wrote:
>
>> On Sat, Aug 19, 2023 at 3:37 AM Tomaz Canabrava <tcanabrava at kde.org>
>> wrote:
>>
>>> (some help / I need to set the default branch to master, from main,
>>> because the tooling doesn't accept the later, I don't think I have the
>>> permission to do that).
>>>
>>
>> That has been done now.
>>
>> Cheers,
>> Ben
>>
>>
>>>
>>> On Fri, Aug 18, 2023 at 5:10 PM Tomaz Canabrava <tcanabrava at kde.org>
>>> wrote:
>>>
>>>> Small update that the CI is now fully passing.
>>>>
>>>> On Fri, Aug 18, 2023 at 2:25 PM Tomaz Canabrava <tcanabrava at kde.org>
>>>> wrote:
>>>>
>>>>> Carl, Sysadmins:
>>>>>
>>>>> The current error on the KDE ci is this:
>>>>>
>>>>> Looking for clang tool headers at /usr/lib64/clang/16.0.6/include. You
>>>>> can change this by defining CT_CLANG_HEADERS_DIR
>>>>> CMake Error at CMakeLists.txt:87 (message):
>>>>> Cannot find clang tool headers at /usr/lib64/clang/16.0.6/include
>>>>> -- Configuring incomplete, errors occurred!
>>>>>
>>>>> (to which I understand that carl said there's an error with Clang6.
>>>>> This is not an error - it basically says that we are unable to find
>>>>> `stddef.h` on the  path `
>>>>> ${LLVM_LIBRARY_DIR}/clang/${LLVM_PACKAGE_VERSION}/include`
>>>>>
>>>>> This is needed for the tool to run properly, but not compile, so I
>>>>> removed the FATAL from the message.
>>>>>
>>>>> On Thu, Aug 17, 2023 at 6:51 PM Tomaz Canabrava <tcanabrava at kde.org>
>>>>> wrote:
>>>>>
>>>>>>
>>>>>>
>>>>>> On Thu, 17 Aug 2023 at 18:29 Carl Schwan <carl.schwan at gnupg.com>
>>>>>> wrote:
>>>>>>
>>>>>>> On Thursday, August 17, 2023 11:18:24 AM CEST Tomaz Canabrava wrote:
>>>>>>> > Hello Fellow KDE Devs,
>>>>>>> >
>>>>>>> > I'm here, formally asking for a review of the Codevis project, to
>>>>>>> move
>>>>>>> > forward and make it a part of kdesdk.
>>>>>>>
>>>>>>> Very cool project, I was amazed by the presentation of it from
>>>>>>> tarcisio at
>>>>>>> Akademy.
>>>>>>>
>>>>>>> > Currently we are using parts of KWdigetsAddons as a submodule
>>>>>>> > Most things that are related to buildsystems will be moved to
>>>>>>> craft /
>>>>>>> > kdesrc-build as soon as possible, right now we rely in conan for
>>>>>>> windows
>>>>>>> > and mac, plus a hand-written build script that downloads and
>>>>>>> builds llvm
>>>>>>> > for those platforms.
>>>>>>> >
>>>>>>> > Things that I know that are out of KDE Accordance:
>>>>>>> > - Translation System (uses Qt's tr() system)
>>>>>>>
>>>>>>> This isn't an issue and we have other KDE projects using the tr()
>>>>>>> system. But
>>>>>>> if you want to port to ki18n, it's best to do it now since you don't
>>>>>>> seems to
>>>>>>> have any translations yet.
>>>>>>>
>>>>>>> > - Settings System (it uses my own configuration parser that
>>>>>>> resembles QML)
>>>>>>>
>>>>>>> Yeah probably best to use kconfigxt or make your configuration
>>>>>>> parser part of
>>>>>>> kconfigxt next gen ;)
>>>>>>>
>>>>>>> > - Folder naming specification (follows the lakosian naming
>>>>>>> specification)
>>>>>>>
>>>>>>> I don't think we have any folder (and file) naming specification in
>>>>>>> kde, or at
>>>>>>> least if we have one, it varies a lot between projects.
>>>>>>>
>>>>>>> > - CI used is based on Gitlab, but fails on KDE
>>>>>>>
>>>>>>> When trying to build it on my laptop it failed, due to the
>>>>>>> requirement of
>>>>>>> clang 16. This might also be an issue with the kde ci on tumbleweed.
>>>>>>
>>>>>>
>>>>>> Carl,
>>>>>>
>>>>>> There’s no requirement for clang16 (I build with 15, tarcisio builds
>>>>>> with 14, the previous ci had 13, I believe)
>>>>>>
>>>>>> Mind if you share the build logs?
>>>>>>
>>>>>> Best
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>>
>>>>>>> > The current repository of Codevis is:
>>>>>>> > https://invent.kde.org/tcanabrava/codevis
>>>>>>> >
>>>>>>> > The KDE developers on this project are me, tarcisio fischer (that
>>>>>>> presented
>>>>>>> > Codevis on Akademy), and Richard Dale.
>>>>>>> >
>>>>>>> > Best regards,
>>>>>>> > Tomaz
>>>>>>>
>>>>>>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20230827/975fdd03/attachment.htm>