Review of Codevis (ie - Making Codevis a KDE Project)

[Carl Schwan]

On Thursday, August 17, 2023 11:18:24 AM CEST Tomaz Canabrava wrote:
> Hello Fellow KDE Devs,
> 
> I'm here, formally asking for a review of the Codevis project, to move
> forward and make it a part of kdesdk.

Very cool project, I was amazed by the presentation of it from tarcisio at 
Akademy.

> Currently we are using parts of KWdigetsAddons as a submodule
> Most things that are related to buildsystems will be moved to craft /
> kdesrc-build as soon as possible, right now we rely in conan for windows
> and mac, plus a hand-written build script that downloads and builds llvm
> for those platforms.
> 
> Things that I know that are out of KDE Accordance:
> - Translation System (uses Qt's tr() system)

This isn't an issue and we have other KDE projects using the tr() system. But 
if you want to port to ki18n, it's best to do it now since you don't seems to 
have any translations yet.

> - Settings System (it uses my own configuration parser that resembles QML)

Yeah probably best to use kconfigxt or make your configuration parser part of 
kconfigxt next gen ;)

> - Folder naming specification (follows the lakosian naming specification)

I don't think we have any folder (and file) naming specification in kde, or at 
least if we have one, it varies a lot between projects.

> - CI used is based on Gitlab, but fails on KDE

When trying to build it on my laptop it failed, due to the requirement of 
clang 16. This might also be an issue with the kde ci on tumbleweed.

> The current repository of Codevis is:
> https://invent.kde.org/tcanabrava/codevis
> 
> The KDE developers on this project are me, tarcisio fischer (that presented
> Codevis on Akademy), and Richard Dale.
> 
> Best regards,
> Tomaz

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20230817/f105d4b1/attachment.sig>