New repo in kdereview: KWeather

Nate Graham nate at kde.org
Wed Nov 30 03:33:12 GMT 2022


This happens on X11 when using QtDialogs for reasons I don't understand. 
See 
https://invent.kde.org/frameworks/knewstuff/-/commit/ea19fa6e824650f3257e8047d6f90e01899b2e03.

Nate


On 11/29/22 16:48, Devin wrote:
> Hmm, I have no idea why the behaviour is different for you, but I get:
> https://i.imgur.com/CvGD8HS.png
> 
> If you removed the "Qt.Dialog" flag here:
> https://invent.kde.org/plasma-mobile/kweather/-/blob/master/src/qml/settings/SettingsWindow.qml#L14,
> does it still have the issue?
> 
> Thanks,
> Devin
> 
> On Tue, Nov 29, 2022 at 6:44 PM Albert Astals Cid <aacid at kde.org> wrote:
>>
>> El dimecres, 30 de novembre de 2022, a les 0:33:39 (CET), Devin va escriure:
>>>> Ok, now that i updated kirigami-addons, the Settings dialog shows, but
>>>> it's uncloseable, any idea why that would be?
>>> That's very strange, it should be showing up as a regular window, does
>>> pressing the close button on the window decoration not work?
>>
>> Which close button?
>>
>> https://i.imgur.com/2jX2yUS.png
>>
>> Cheers,
>>    Albert
>>
>>>
>>> Thanks,
>>> Devin
>>>
>>> On Tue, Nov 29, 2022 at 6:23 PM Albert Astals Cid <aacid at kde.org> wrote:
>>>> El dilluns, 28 de novembre de 2022, a les 17:15:57 (CET), Albert Astals
>>>> Cid va>
>>>> escriure:
>>>>> El divendres, 25 de novembre de 2022, a les 4:46:40 (CET), Devin va
>>>>
>>>> escriure:
>>>>>>> There's potentially overlapping text.
>>>>>>
>>>>>> I have fixed text wrapping in the weather delegates so it should wrap
>>>>>> properly now.
>>>>>>
>>>>>>> Here settingsModel.forecastStyle is not i18n'ed
>>>>>>
>>>>>> I have fixed it now (it converts to i18n'd dedicated strings in the
>>>>>> QML)
>>>>>
>>>>> FWIW i can't open settings anymore
>>>>>
>>>>> qrc:/qml/settings/SettingsWindow.qml:56:13: Type SettingsComponent
>>>>> unavailable qrc:/qml/settings/SettingsComponent.qml:61:17: Cannot assign
>>>>> to
>>>>> non-existent property "onActivated" qrc:/qml/main.qml:136: TypeError:
>>>>> Cannot call method 'close' of null
>>>>
>>>> Ok, now that i updated kirigami-addons, the Settings dialog shows, but
>>>> it's
>>>> uncloseable, any idea why that would be?
>>>>
>>>> Cheers,
>>>>
>>>>    Albert
>>>>
>>>>> Cheers,
>>>>>
>>>>>    Albert
>>>>>
>>>>>> On Mon, Nov 14, 2022 at 5:10 PM Albert Astals Cid <aacid at kde.org>
>> wrote:
>>>>>>> El dimecres, 9 de novembre de 2022, a les 23:00:13 (CET), Devin va
>>>>
>>>> escriure:
>>>>>>>> Hi everyone,
>>>>>>>>
>>>>>>>> I would like to put kweather through kdereview:
>>>>>>>>
>>>>>>>> https://invent.kde.org/plasma-mobile/kweather
>>>>>>>>
>>>>>>>> KWeather is an application that can give simple weather
>>>>>>>> information
>>>>>>>> for different weather locations. Please note that KWeatherCore
>>>>>>>> (the
>>>>>>>> library the app depends on) has already passed kdereview.
>>>>>>>
>>>>>>> There's potentially overlapping text.
>>>>>>>
>>>>>>> See https://i.imgur.com/BrOgi3A.png
>>>>>>>
>>>>>>> The settings show untranslateable text, i.e.
>>>>>>>
>>>>>>> MobileForm.FormComboBoxDelegate {
>>>>>>>
>>>>>>>                  id: forecastStyleDropdown
>>>>>>>                  text: i18n("Forecast Style")
>>>>>>>                  currentValue: settingsModel.forecastStyle
>>>>>>>
>>>>>>> Here settingsModel.forecastStyle is not i18n'ed
>>>>>>>
>>>>>>> Not KWeather's fault but i just realized that Kirigami's about page
>>>>>>> doesn't
>>>>>>> properly credit translators :/
>>>>>>>
>>>>>>> Cheers,
>>>>>>>
>>>>>>>    Albert
>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Devin
>>
>>
>>
>>


More information about the kde-core-devel mailing list