New repo in kdereview: KWeather

[Albert Astals Cid]

El dilluns, 28 de novembre de 2022, a les 20:18:14 (CET), Devin va escriure:
> > Depending on an unreleased version of a dependency is not acceptable if
> > you
> > want to release your application (which it is my understanding of what
> > you're aiming given you're asking us to review it).
> 
> It's a bit of a strange situation since KWeather had already been
> released along with Kirigami Addons in Plasma Mobile Gear for a bit
> more than a year.
> 
> Kirigami Addons had a breaking change for this release, which is why
> KWeather had to update its API usage (they are released at the same
> time).

You've been told that you need to increase your minimum dependency in another 
email, i'll do it again.

Increase your required version of kirigami addons so that it matches reality.

Cheers,
  Albert

> 
> Thanks,
> Devin
> 
> On Mon, Nov 28, 2022 at 12:23 PM Albert Astals Cid <aacid at kde.org> wrote:
> > El dilluns, 28 de novembre de 2022, a les 17:53:59 (CET), Devin va 
escriure:
> > > > FWIW i can't open settings anymore
> > > 
> > > Make sure you have the latest kirigami-addons built (from master).
> > 
> > Depending on an unreleased version of a dependency is not acceptable if
> > you
> > want to release your application (which it is my understanding of what
> > you're aiming given you're asking us to review it).
> > 
> > Cheers,
> > 
> >   Albert
> >   
> > > Thanks,
> > > Devin
> > > 
> > > On Mon, Nov 28, 2022 at 11:15 AM Albert Astals Cid <aacid at kde.org> 
wrote:
> > > > El divendres, 25 de novembre de 2022, a les 4:46:40 (CET), Devin va
> > 
> > escriure:
> > > > > > There's potentially overlapping text.
> > > > > 
> > > > > I have fixed text wrapping in the weather delegates so it should
> > > > > wrap
> > > > > properly now.
> > > > > 
> > > > > > Here settingsModel.forecastStyle is not i18n'ed
> > > > > 
> > > > > I have fixed it now (it converts to i18n'd dedicated strings in the
> > > > > QML)
> > > > 
> > > > FWIW i can't open settings anymore
> > > > 
> > > > qrc:/qml/settings/SettingsWindow.qml:56:13: Type SettingsComponent
> > > > unavailable qrc:/qml/settings/SettingsComponent.qml:61:17: Cannot
> > > > assign
> > > > to non-existent property "onActivated" qrc:/qml/main.qml:136:
> > > > TypeError:
> > > > Cannot call method 'close' of null
> > > > 
> > > > Cheers,
> > > > 
> > > >   Albert
> > > >   
> > > > > On Mon, Nov 14, 2022 at 5:10 PM Albert Astals Cid <aacid at kde.org> 
wrote:
> > > > > > El dimecres, 9 de novembre de 2022, a les 23:00:13 (CET), Devin va
> > 
> > escriure:
> > > > > > > Hi everyone,
> > > > > > > 
> > > > > > > I would like to put kweather through kdereview:
> > > > > > > 
> > > > > > > https://invent.kde.org/plasma-mobile/kweather
> > > > > > > 
> > > > > > > KWeather is an application that can give simple weather
> > > > > > > information
> > > > > > > for different weather locations. Please note that KWeatherCore
> > > > > > > (the
> > > > > > > library the app depends on) has already passed kdereview.
> > > > > > 
> > > > > > There's potentially overlapping text.
> > > > > > 
> > > > > > See https://i.imgur.com/BrOgi3A.png
> > > > > > 
> > > > > > The settings show untranslateable text, i.e.
> > > > > > 
> > > > > > MobileForm.FormComboBoxDelegate {
> > > > > > 
> > > > > >                 id: forecastStyleDropdown
> > > > > >                 text: i18n("Forecast Style")
> > > > > >                 currentValue: settingsModel.forecastStyle
> > > > > > 
> > > > > > Here settingsModel.forecastStyle is not i18n'ed
> > > > > > 
> > > > > > Not KWeather's fault but i just realized that Kirigami's about
> > > > > > page
> > > > > > doesn't
> > > > > > properly credit translators :/
> > > > > > 
> > > > > > Cheers,
> > > > > > 
> > > > > >   Albert
> > > > > >   
> > > > > > > Thanks,
> > > > > > > Devin