Eloquens now on KDEREVIEW)

[Felipe Kinoshita]

friendly ping! :)

On Wed, Jun 22, 2022 at 5:44 PM Felipe Kinoshita <kinofhek at gmail.com> wrote:
>
> > Ah! I would suggest moving the conversion into the Controller then. As
> > far as kcfg, your Config object and your Settings.qml are concerned
> > they can be proper bools, it's only in the Controller that you have
> > the presentation requirement that bools must be 0/1. This saves you
> > the two-way conversion, in the Controller you only need to convert
> > bool=>int and the rest of the app can treat them as proper bools.
>
> Indeed, this makes much more sense.
>
> Fixed it now!
>
> Thanks,
> Felipe
>
> On Wed, Jun 22, 2022 at 10:10 AM Harald Sitter <sitter at kde.org> wrote:
> >
> > On Wed, Jun 22, 2022 at 12:07 AM Felipe Kinoshita <kinofhek at gmail.com> wrote:
> > >
> > > > Could you elaborate why your config.kcfg uses Ints for everything when
> > > > you clearly want booleans (e.g. `Config.code == 1 ? true : false`)
> > >
> > > The API expects ones and zeros for its params, I chose to convert them to
> > > booleans to make the API call easier to write and change.
> >
> > Ah! I would suggest moving the conversion into the Controller then. As
> > far as kcfg, your Config object and your Settings.qml are concerned
> > they can be proper bools, it's only in the Controller that you have
> > the presentation requirement that bools must be 0/1. This saves you
> > the two-way conversion, in the Controller you only need to convert
> > bool=>int and the rest of the app can treat them as proper bools.
> >
> > HS