Docker CI Image Change Freeze

[Albert Astals Cid]

El dilluns, 12 de desembre de 2022, a les 18:28:08 (CET), Ben Cooksley va escriure:
> On Mon, Dec 12, 2022 at 12:29 PM Albert Astals Cid <aacid at kde.org> wrote:
> > El dimarts, 29 de novembre de 2022, a les 10:15:33 (CET), Ben Cooksley va
> > 
> > escriure:
> > > Hi all,
> > > 
> > > As an update to this, sufficient changes have been made within Craft
> > > that
> > > it is now possible to build Qt 5 images so i'm releasing the freeze for
> > > those images.
> > > Qt 6 remains broken, and therefore remains frozen at this time (see
> > > https://invent.kde.org/sysadmin/ci-images/-/jobs/619808)
> > > 
> > > As mentioned previously, I believe this to be a CMake bug given the lack
> > 
> > of
> > 
> > > change in Ninja.
> > > 
> > > At this stage I would suggest investigation be focused on either
> > 
> > upgrading
> > 
> > > to a newer version of Ninja that can handle the newer version of CMake,
> > 
> > or
> > 
> > > downgrading CMake back to an older version that is compatible with Ninja
> > > being built without re2c being available.
> > > 
> > > Qt 6 CI will be globally disabled in 2 weeks time if this remains
> > 
> > unfixed,
> > 
> > > as dependencies move quickly and I'm not in favour of retaining parts of
> > > the CI system which cannot be rebuilt.
> > 
> > This is now done, don't be like me and waste your time trying to figure
> > out why
> > it works when it's not supposed to work.
> 
> Please note that the underlying reason for Ninja failing to compile within
> the CI Image build environment was never found, 

Are you sure about that?

Isn't https://invent.kde.org/packaging/craft/-/commit/49670cd2772e352df64749dd59d3a0437bf09d26 the fix?

Cheers,
  Albert

> however it was worked
> around by using a pre-built version from Craft's cache.
> At some point in time in the not too distant future we will begin building
> Craft caches within our Docker images as well, which may expose this
> problem again.
> 
> For now though the immediate issue is resolved though yes.
> 
> > Cheers,
> > 
> >   Albert
> 
> Cheers,
> Ben
> 
> > > Regards,
> > > Ben
> > > 
> > > On Sat, Nov 19, 2022 at 7:55 AM Ben Cooksley <bcooksley at kde.org> wrote:
> > > > Hi all,
> > > > 
> > > > Recently Sysadmin received a series of requests to rebuild the Docker
> > > > images used to support KDE CI services on invent.kde.org.
> > > > 
> > > > Unfortunately one of these rebuilds has exposed a bug of unknown
> > > > origin
> > > > (as it fails on our side but by all accounts works elsewhere) where
> > 
> > Craft
> > 
> > > > is unable to compile Ninja (with the compilation dying due to a
> > 
> > Makefile
> > 
> > > > syntax error that looks like a CMake bug).
> > > > 
> > > > The failure log can be found at
> > > > https://invent.kde.org/sysadmin/ci-images/-/jobs/601722
> > > > 
> > > > Subsequent to this we have also received a request to rebuild our
> > > > Linux
> > > > images to allow for Grantlee 5.3 to be used.
> > > > 
> > > > Given how development is conducted within some projects that make
> > > > heavy
> > > > use of Grantlee, and how some of that technology is used across
> > 
> > multiple
> > 
> > > > platforms it would be harmful to the wider CI system and KDE Community
> > 
> > to
> > 
> > > > allow for Grantlee 5.3 to become available on any of our platforms.
> > > > 
> > > > I'm therefore imposing a change freeze on all KDE CI Docker images
> > 
> > until
> > 
> > > > the issue with Craft/Ninja/CMake is resolved.
> > > > 
> > > > Should any project have prematurely adopted a mandatory dependency on
> > > > Grantlee 5.3 then as they have failed to follow the correct change
> > 
> > process
> > 
> > > > as documented on our wikis that change is deemed to be outside policy
> > 
> > and
> > 
> > > > should be reverted immediately.
> > > > 
> > > > Regards,
> > > > Ben Cooksley
> > > > KDE Sysadmin