New repo in kdereview: kalk

[Thomas Baumgart]

Han,

On Dienstag, 4. Mai 2021 11:36:04 CEST hanyoung wrote:

> Pushed an inelegant solution - include "," as decimal separator in flex. As long as there aren't any more decimal separator we're cool.

Not sure if this appropriate, but I wanted to warn you about the dilemma that in some locale the thousand separator and the decimal symbol are exactly the opposite. Example:

   German locale: 1.000,00  -> one thousand
   US locale    : 1,000.00  -> one thousand

So simply treating the comma and the dot alike without taking the locale into account may result in wrong values.

Cheers,

Thomas


> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> On Tuesday, May 4, 2021 6:54 AM, Albert Astals Cid <aacid at kde.org> wrote:
> > Added a failing test athttps://invent.kde.org/plasma-mobile/kalk/-/merge_requests/22
> >
> > Now you have to make it work :)
> >
> > Cheers,
> > Albert
> 
> 
> 

-- 

Regards

Thomas Baumgart

https://www.signal.org/       Signal, the better WhatsApp
-------------------------------------------------------------
Of all the computing resources available, the most valuable one is
programmers' time. Especially in open source where most of us have to
sneak in time to write and debug code. (Ace Jones)
-------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 868 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20210504/cc35ce4e/attachment.sig>