New repo in kdereview: kclock

[Albert Astals Cid]

El divendres, 5 de març de 2021, a les 3:04:24 CET, hanyoung va escriure:
> Hello everyone!
> I want to move kclock to kdereview.
> 
> https://invent.kde.org/plasma-mobile/kclock
> 
> KClock is the alarm/clock app for Plasma Mobile. It consists of two parts, daemon and the client. The daemon communicates with powerdevil to register alarms, and provide DBus interface to interact with the client.
> 
> Besides the daemon and the client, some plasmoids also included in the repo, although only one is enabled so far.

New Timer doesn't work? Ah it's because it needs kclockd running for that, would it be very hard to give a warning if it isn't running?

Is that kirigamiaddons thing released? Seems to be the reason i can't add new Alarms

Not an expert in UI but for stopwatch having Start/Pause on the top left feels a bit unnatural, maybe would make sense swapping reset and Start? Ask the VDG i guess.

Also in stopwatch for me it'd make a lot of sense if pressing the time starts/pauses, what do you think?

Silence Alarm After shows an horizontal scrollbar that doesn't to be very useful https://i.imgur.com/7O8DBJc.png

It's even worse in Alarm Snooze Length where it goes over existing text https://i.imgur.com/KwWZzNz.png

You're missing Messages.sh in kclockd

Please check i18n in your qml files, these seem like need i18n

./src/kclock/qml/BottomToolbar.qml:55:                    name: "Time"
./src/kclock/qml/BottomToolbar.qml:59:                    name: "Timer"
./src/kclock/qml/BottomToolbar.qml:63:                    name: "Stopwatch"
./src/kclock/qml/BottomToolbar.qml:67:                    name: "Alarm"
./src/kclock/qml/BottomToolbar.qml:71:                    name: "Settings"

There you are trying to translate later doing i18n(model.name), and it very incidentally works because those texts are extracted in other files, but if you didn't have the i18n() for those texts in Sidebar.qml it wouldn't since nothing would know that those strings need to be extracted and translators have to translate them, seems a bit fragile


./src/kclock/qml/SettingsPage.qml:187:                        name: "30 seconds"
./src/kclock/qml/SettingsPage.qml:191:                        name: "1 minute"
./src/kclock/qml/SettingsPage.qml:195:                        name: "5 minutes"
./src/kclock/qml/SettingsPage.qml:199:                        name: "10 minutes"
./src/kclock/qml/SettingsPage.qml:203:                        name: "15 minutes"
./src/kclock/qml/SettingsPage.qml:207:                        name: "Never"
./src/kclock/qml/SettingsPage.qml:242:                        name: "1 minute"
./src/kclock/qml/SettingsPage.qml:246:                        name: "2 minutes"
./src/kclock/qml/SettingsPage.qml:250:                        name: "3 minutes"
./src/kclock/qml/SettingsPage.qml:254:                        name: "4 minutes"
./src/kclock/qml/SettingsPage.qml:258:                        name: "5 minutes"
./src/kclock/qml/SettingsPage.qml:262:                        name: "10 minutes"
./src/kclock/qml/SettingsPage.qml:266:                        name: "30 minutes"
./src/kclock/qml/SettingsPage.qml:270:                        name: "1 hour"

/src/kclock/qml/AlarmListPage.qml:148:        if (dayOfWeek & monday) str += "Mon., ";
./src/kclock/qml/AlarmListPage.qml:149:        if (dayOfWeek & tuesday) str += "Tue., ";
./src/kclock/qml/AlarmListPage.qml:150:        if (dayOfWeek & wednesday) str += "Wed., ";
./src/kclock/qml/AlarmListPage.qml:151:        if (dayOfWeek & thursday) str += "Thu., ";
./src/kclock/qml/AlarmListPage.qml:152:        if (dayOfWeek & friday) str += "Fri., ";
./src/kclock/qml/AlarmListPage.qml:153:        if (dayOfWeek & saturday) str += "Sat., ";
./src/kclock/qml/AlarmListPage.qml:154:        if (dayOfWeek & sunday) str += "Sun., ";

./src/kclock/qml/AboutPage.qml:55:                        "text" : "long, boring, license text",


Cheers,
  Albert

> 
> Regards,
> Han
>