Haruna in kdereview

[Jonah Brüchert]

> - you should codify the runtime dep on youtube-dl via cmake. make a
> dummy finder and set_package_properties it as type RUNTIME e.g.
> https://invent.kde.org/plasma/plasma-disks/-/blob/master/cmake/Findsmartctl.cmake


In AudioTube I've been using this FindYoutubeDl module. Maybe you can 
make use of it too.

And if someone on the list finds a problem with it, let me know so I can 
also fix it in AudioTube.


> # SPDX-FileCopyrightText: 2021 Jonah Brüchert <jbb at kaidan.im>
> #
> # SPDX-License-Identifier: BSD-2-Clause
>
> find_package(Python3 REQUIRED COMPONENTS Interpreter)
>
> execute_process(COMMAND ${Python3_EXECUTABLE} -c "import youtube_dl" 
> RESULT_VARIABLE YTDL_CHECK_RESULT)
>
> if (${YTDL_CHECK_RESULT} EQUAL 0)
>         set(YoutubeDL_FOUND TRUE)
> endif()

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xA81E075ABEC80A7E.asc
Type: application/pgp-keys
Size: 11172 bytes
Desc: OpenPGP public key
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20210721/c7500896/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20210721/c7500896/attachment-0001.sig>