KHealthCertificate in kdereview

[Volker Krause]

On Sonntag, 11. Juli 2021 16:07:37 CEST Friedrich W. H. Kossebau wrote:
> Quick feedback after looking at the cmake code:
> 
> * do not explicitly list ECM_KDE_MODULE_DIR, it is part of ECM_MODULE_PATH
> * do not use KDEFrameworkCompilerSettings for non-KF projects, only
> KDECompilerSettings
> * no need to set CMAKE_AUTOMOC & CMAKE_AUTORCC, done by KDECompilerSettings
> for required ECM
> * set(CMAKE_CXX_STANDARD 17) before including KDECompilerSettings
> * call feature_summary as last thing, for consistency and some logic in
> execution
> * avoid REQUIRED in find_package() calls, only use in
> set_package_properties, so cmake will not cancel in middle of run, but get
> to listing found/notfound summary (Qt, ECM, KF are harder to do here due to
> macros expected later, and usually present, so fine there)
> * include the 3 KDE cmake setting modules as first and in this order:
>   include(KDEInstallDirs)
>   include(KDECMakeSettings)
>   include(KDECompilerSettings NO_POLICY_SCOPE)
> * I recommend using set_target_properties() right next to add_${target},
>   easier to find on need and product definition in one place makes more
> sense

done, with the exception of switching away from KDEFrameworksCompilerSettings, 
that can only be done for 5.85, for earlier versions that would require 
copying a bunch of settings it seems.

Thanks,
Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20210711/92fd0d77/attachment.sig>