Plasma Bigscreen in Kdereview

[Albert Astals Cid]

El dilluns, 25 de gener de 2021, a les 11:27:11 CET, Marco Martin va escriure:
> On Sun, Jan 24, 2021 at 10:19 PM Albert Astals Cid <aacid at kde.org> wrote:
> >
> > > we just converted license headers to SPDX, the code should be in
> > > fairly good shape by now
> >
> > The ATTRIBUTION file on the root feels like it would need some qualification over to which files it applies.
> >
> > There's a few
> >      KPackage components should be specified in reverse domain notation.
> > on cmake time, not sure how bad those are.
> 
> What are those that are not ok? i can only see it in kcms, which need
> to have same package name as the kcm library name, so usually kcm_foo
> like all those in plasma-desktop do as well

  kcms/audio-device-chooser/CMakeLists.txt:25 (kpackage_install_package)
  kcms/wifi/CMakeLists.txt:25 (kpackage_install_package)
  kcms/kdeconnect/CMakeLists.txt:25 (kpackage_install_package)

Cheers,
  Albert