Plasma Firewall on KDE Review

[Tomaz Canabrava]

Kevin,

Yes, this inherited the base code from nx-firewall.
I'll see how easy is to implement this on the current codebase without
missing deadline for plasma 21.

Tomaz


On Fri, Jan 22, 2021 at 11:54 PM Kevin Kofler <kevin.kofler at chello.at>
wrote:

> Tomaz Canabrava wrote:
> > Please review the code and test.
>
> Unfortunately, this appears to have inherited the usability issues from
> nx-firewall:
> https://invent.kde.org/network/plasma-firewall/-/issues/14
> https://invent.kde.org/network/plasma-firewall/-/issues/15
> and a new one comes up with the added support for firewalld:
> https://invent.kde.org/network/plasma-firewall/-/issues/16
>
> IMHO, support for application profiles (#14) is essential for a usable
> firewall UI. (IMHO, it is the absolute minimum. For firewalld, you also
> need
> to handle the concept of zones sooner or later, see #16.)
>
> A simpler way to create simple rules (only setting the incoming port,
> without needing the advanced settings) (#15) would also be helpful, though
> you may be able to get away without it if you address #14.
>
>         Kevin Kofler
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20210125/c01a382b/attachment.htm>