kpeoplevcard in kdereview

[Nicolas Fella]

On 14/06/2021 21:28, Albert Astals Cid wrote:
> El dissabte, 12 de juny de 2021, a les 15:56:36 (CEST), Nicolas Fella va escriure:
>> Hi,
>>
>> https://invent.kde.org/pim/kpeoplevcard is now in kdereview.
>>
>> kpeoplevcard is a data source plugin for KPeople that provides contacts
>> based on VCard files on the disk. The 0.1 release has been in use in
>> plasma-phonebook and kdeconnect-sms for a while, but I just realized it
>> was never properly reviewed.
>>
>> I did some cleanup work to bring the repo up to standards, but in
>> general the thing is rather "finished". There is a pending MR adding
>> full REUSE compliance waiting for approval from the copyright holders.
> There's i18n but no Messages.sh nor -DTRANSLATION_DOMAIN= (assuming this is a lib or similar and it makes sense to use -DTRANSLATION_DOMAIN=)
>
> Cheers,
>    Albert

Thanks, fixed with
https://invent.kde.org/pim/kpeoplevcard/-/commit/c6a135a47146279aaaa77f9c1caee4a352c995e9

Cheers

Nico