Move Koko to KDEReview

[Yuri Chornoivan]

10 червня 2020, 11:35:37, від "Carl Schwan" <carl at carlschwan.eu>:

> Hi,
> 
> I would like to move Koko, a convergent image viewer, to KDEReview.
> Koko is already shipped in the base Plasma mobile image and I was
> surprised that it was still in playground. The current devs are mostly
> Nicolas, Marco and me.
> 
> Koko is following the KDE HIG and is build using QtQuick and the
> Kirigami framework.
> 
> The repo is located here: https://invent.kde.org/plasma-mobile/koko/.
> There is only one know big issue, but it is in the progress of
> being resolved[1].
> 
> In the future, I plan to add a simple image editor that is currently
> being developed as a separate and reusable library. More info about
> it is available in my latest blog post[2].
> 
> I would be happy if it could be reviewed and my goal is to move it to
> the release service, I hope in time for 20.08.
> 
> From the release sanity checklist:
> 
> * licensing should be ok (LGPL-2.1-only or LGPL-3.0-only or
> LicenseRef-KDE-Accepted-LGPL), but some headers are missing in the
> CMake files :/
> * A Messages.sh file is missing and help would be welcome to figure
> out if Koko need one since translations are regularly being pushed by
> scripty.

Added. Scripty will extract the catalog for translation tomorrow.

But I bet the translations will not be loaded because of the lack of KAboutData and friends. See KLook:

https://invent.kde.org/graphics/klook/-/blob/master/src/main.cpp

Hope this helps and thanks for your work.

Best regards,
Yuri

> * Screenshot is missing but I plan to add one before the release.
> * CI works and there is a .gitlab-ci.yml file.
> * There is an AppStream file.
> * There is some documentation on userbase: https://userbase.kde.org/Koko
> I plan to also update it before the next release.
> 
> Carl Schwan
> https://carlschwan.eu
> 
> [1]: https://invent.kde.org/plasma-mobile/koko/-/merge_requests/20
> [2]: https://carlschwan.eu/2020/06/06/koko-desktop.html
>