plasma-disks in kdereview

[Harald Sitter]

On Wed, Aug 5, 2020 at 12:00 AM Albert Astals Cid <aacid at kde.org> wrote:
>
> El dimarts, 4 d’agost de 2020, a les 15:46:20 CEST, Harald Sitter va escriure:
> > Hey
> >
> > It'd be awesome if I could get some eyes at the new
> > https://invent.kde.org/system/plasma-disks which implements smart
> > monitoring as requested in https://bugs.kde.org/show_bug.cgi?id=254313
> > I've opted to not put it in kinfocenter directly because it is a bit
> > much with its own kded module and kauth helper, plus I guess there's
> > an opportunity to add further monitoring tech for RAIDs or something.
> > It still targets plasma releases though.
> >
> > This runtime depends on smartctl (from smartmontools) to read the
> > smart status via a kauth helper. Device states are managed inside a
> > kded that maps the devices into dbus from which the kinfocenter KCM
> > then loads the data for visualization.
>
> I have a feeling that the qml i18n's won't work pick up the correct domain, the -DTRANSLATION_DOMAIN only sets the domain for the C++ calls.

Good point. qml extraction was missing too.
As it turns out the qml kcms get their domain name from the kaboutdata
componentname, so I rejiggered the kcm accordingly and the x-test l10n
now works. I do wonder if it'd make more sense to make the kcm a
separate translation domain altogether, calling everything
plasma_disks feels a bit awkward. At the same time having 2
translation domains for 10 strings seems silly too :S

HS