Kup in KDE Review

[Adriaan de Groot]

On Monday, 6 April 2020 12:32:54 CEST Simon Persson wrote:
> Please help to review kup.

- It's probably worthwhile looking at REUSE licensing compliance (see 
reuse.software, or ask on IRC #kde-devel) so that the license is machine-
readable and checkable.
- Although you find_package(LibGit2) you were linking "old style" instead of 
using the imported target LibGit2::LibGit2. I pushed a build fix, now it 
builds on FreeBSD as well.


- Uses a handful of deprecated methods; depending on what exactly you want to 
be compatible with, you might chase those.


[ade]