Review Request: plasma-thunderbolt

Albert Astals Cid aacid at
Wed May 15 22:08:57 BST 2019

El dimecres, 15 de maig de 2019, a les 15:27:07 CEST, Daniel Vrátil va escriure:
> Hi all,
> plasma-thunderbolt is a new repo containing, you guessed it, Thunderbolt KCM 
> for Plasma. I initially submitted the code as a patch against plasma-desktop 
> [0], where it got reviewed, but it was ultimately decided to better put it 
> into a separate repository, since it's not just a KCM but also a library and a 
> KDED module. I have backported all the changes from the Phabricator review 
> back to the repository, so the code in the repo is identical to the one in the 
> Phab review (minus buildsystem changes and a small build fix for clang).
> However, since this is still a new code, it must formally pass through 
> kdereview before I can submit it into Plasma as a new module.
> Thus I'd kindly ask you to take one more look at the codebase [1] and let me 
> know if there are any more issues to fix, or if we can proceed to include this 
> in the next Plasma release.

There's this cmake warning

CMake Warning at /usr/lib64/cmake/KF5Package/KF5PackageMacros.cmake:74 (message):
  KPackage components should be specified in reverse domain notation.
  Appstream information won't be generated for kcm_bolt.
Call Stack (most recent call first):
  src/kcm/CMakeLists.txt:22 (kpackage_install_package)

clazy complains about a few Q_PROPERTY that should ideally either have a NOTIFY signal or be marked as CONSTANT

it also complains about a few const slots that return values. Seems like what you want is to actually mark them as invokable/scriptable and not as slots?


> Thanks,
> - Dan
> [0]
> [1]

More information about the kde-core-devel mailing list