KTimeTracker in kdereview

[Albert Astals Cid]

El diumenge, 1 de desembre de 2019, a les 13:09:30 CET, Alexander Potashev va escriure:
> вт, 26 нояб. 2019 г. в 00:31, Albert Astals Cid <aacid at kde.org>:
> >
> > El dimarts, 19 de novembre de 2019, a les 5:20:23 CET, Alexander Potashev va escriure:
> > > Hi,
> > >
> > > KTimeTracker [1] has been moved to kdereview.
> > >
> > > KTimeTracker is a time tracker desktop application which is well
> > > suited for tracking labor time you spend on a specific
> > > project/feature/customer.
> > >
> > > Its latest release was made on 2015-07-01 as part of KDE PIM 4.14.10.
> > > Since then I ported KTimeTracker to Qt5/KF5, did a lot of refactoring
> > > and reworked some dialogs. The major changes since 4.14.10 are listed
> > > in [2].
> > >
> > > KDE CI is set up at [3].
> > >
> > > The project is currently in playground-pim, destination would be extragear-pim.
> >
> > clang-tidy says that desktops in Task::Task and sessionStartTiMe in Task::init should be const &
> 
> Fixed these [1], however I wasn't able to run clang-tidy myself to get
> the same hints. Tried clang-tidy features in KDevelop and JetBrains'
> CLion.

clang-tidy has a million checks and almost none are enabled by default (i think)

What i do is enable the performance ones manually, i.e. for example this is what we have in the poppler CI

cmake -DCMAKE_CXX_CLANG_TIDY="clang-tidy;-header-filter=.;-checks=-*,performance-*,bugprone-*,readability-inconsistent-declaration-parameter-name,readability-string-compare,modernize-deprecated-headers,-bugprone-narrowing-conversions,-bugprone-macro-parentheses,-bugprone-suspicious-string-compare,-bugprone-incorrect-roundings,-bugprone-undefined-memory-manipulation;-warnings-as-errors=*" ..

But this will probably give you lots of errors you don't want, you have to figure out which are th eones you care about.

Cheers,
  Albert

> 
> Thanks Albert!
> 
> 
> [1] https://commits.kde.org/ktimetracker/7928253e26d6f6eb2dfe6256fe2cf15fcf9225e4
> 
>