Ring-KDE in kdereview

[Albert Astals Cid]

El diumenge, 11 de febrer de 2018, a les 20:28:37 CET, Elv1313 . va escriure:
> Thanks for the review
> 
> > The automatic fetching of stuff from github on make time was weird.
> 
> It's the fallback if it's not found. It wont do that if:
> 
> 1) it is installed
> 2) the libringqt directory was put in `ring-kde/`.
> 3) It is using a release tarball instead of git-master
> 
> The automatic download was added because otherwise getting all the
> right versions of everything was near impossible.
> 
> > And it doesn't build for me. (I see it's libringqt so maybe not your
> > fault? would get "fixed" if you dodn't do the automatic fetching :D)
> Apparently the daemon and/or libring is not installed correctly. There
> is a cmake check for it, but it is a little permissive to allow
> build.kde.org to only fetch the daemon dbus headers and not compile
> it.
> 
> As I said in the mail above, the only reliable way to compile ring-kde
> is to use the Dockerfile.

That's really very unfortunate.

Cheers,
  Albert

P.S: Remember to keep the list on CC :)