Latte : make_unique for gcc <=4.8

[Tomaz Canabrava]

On Sun, Nov 5, 2017 at 4:12 PM, Michail Vourlakos <mvourlakos at gmail.com>
wrote:

> Hello everyone,
>
> during the review phase in Latte we removed the following code in case it
> would conflict in some cases:
>
> #if __GLIBCXX__ <= 20150623
> namespace std {
> template<class T, class... Args>
> unique_ptr<T> make_unique(Args &&... args)
> {
>     return std::unique_ptr<T>(new T(std::forward<Args>(args)...));
> }
> }
> #endif
>
>
> this was needed for gcc versions that even though they are C++14
> compatible they dont offer make_unique function. By removing that code we
> broke compatibility with openSUSE Leap that uses gcc 4.8.5 ... so in order
> to build latte packages a made a patch to readd that code.
>
> Do you know any better way to handle this?
>

I would say "just drop it altogether" because 4.8.5 is too old and broken
(it's a 2013 release, after all. four years have passed and for programming
this is an eternity) - require a newer compiler.


> regards,
> [michail]
>
>
> BTW: for every e-mail I send I need moderator approval is that a standard
> procedure or I can register somewhere to avoid this?
>

yes, you can: https://mail.kde.org/mailman/listinfo/kde-core-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20171109/ae619b95/attachment.htm>