kdereview: ksmtp

[Daniel Vrátil]

Thanks, totally forgot to run clazy/krazy on the codebase.

On Thursday, May 11, 2017 10:25:36 PM CEST Allen Winter wrote:
> ran clazy level2 . no hits
> 
> ran krazy checks and it found:
> . Check for C++ ctors that should be declared 'explicit' [explicit]... 1
> issue found ./autotests/fakeserver.h: line#36 (1)

Fixed

> 
> . Check for normalized SIGNAL and SLOT signatures [normalize]... 4 issues
> found ./src/session.cpp: SIGNALS: line#285,286 (2)
>         ./src/session.cpp: SLOTS: line#285,286 (2)

Fixed (converted to the new connect() syntax)

> . Check for strings used improperly or should be i18n. [strings]... 5 issues
> found ./autotests/fakeserver.cpp: QLatin1String issues
> line#172,175,190,201,218 (5)

Those are false positives. I guess krazy assumes .startsWith() to be 
QString::startsWith(), while those are QByteArray::startsWith().

Dan

> On Thursday, May 11, 2017 11:03:01 AM EDT Daniel Vrátil wrote:
> > Hi,
> > 
> > please review ksmtp, which is now in kdereview.
> > 
> > KSMTP is a small simple library with a KJob-based API similar to KIMAP or
> > KDAV to send mime messages via SMTP. It was initially written in 2011 by
> > Gregory Schlomoff but since then it's been lying around in playground
> > without any interest or use. I have recently picked it up, ported to
> > Frameworks and improved the job handling and authentication to make the
> > library ussable for KDE PIM and would like to have it released as part of
> > KDE Applications 17.08.
> > 
> > KDE PIM currently uses a custom KIO Slave to send messages via SMTP, which
> > is hard to maintain and extend. Having a Job-based library like KSmtp
> > will make it much easier for us to introduce support for example for
> > Google XOAUTH2 authentication mechanism.
> > 
> > Thanks,
> > Dan


-- 
Daniel Vrátil
www.dvratil.cz | dvratil at kde.org
IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde)

GPG Key: 0x4D69557AECB13683
Fingerprint: 0ABD FA55 A4E6 BEA9 9A83 EA97 4D69 557A ECB1 3683
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20170511/1d7582dd/attachment.sig>