kdereview - xdg-desktop-portal-kde

[Elvis Angelaccio]

On mercoledì 3 maggio 2017 13:11:26 CEST Jan Grulich wrote:
> On středa 3. května 2017 11:28:45 CEST Elvis Angelaccio wrote:
> > On mercoledì 3 maggio 2017 07:00:14 CEST Jan Grulich wrote:
> > > > > > > Do you have xdg-desktop-portal installed?
> > > > > > 
> > > > > > Yes.
> > > > > 
> > > > > Make sure that xdg-desktop-portal is running, it should be started
> > > > > automatically by flatpak, but you never know.
> > > > 
> > > > How do I check it? Is it a process that I should see?
> > > > 
> > > > > Also try to run xdg-desktop-
> > > > > portal-kde with debug enabled using:
> > > > > QT_LOGGING_RULES=xdg-desktop-portal-kde*.debug=true
> > > > > /path/to/xdg-desktop-
> > > > > portal-kde.
> > > > 
> > > > This just prints "Desktop portal registered successfuly", which I
> > > > guess
> > > > is
> > > > ok.
> > > > 
> > > > As soon as the test app freezes (instead of opening the file dialog),
> > > > I
> > > > get
> > > > this in my journalctl: https://paste.kde.org/phcnn4uxn
> > > 
> > > I guess you have to make sure that xdg-desktop-portal-kde is installed
> > > to
> > > correct location. I have it in:
> > > -
> > > /usr/share/dbus-1/services/org.freedesktop.impl.portal.desktop.kde.servi
> > > c
> > > e - /usr/share/xdg- desktop-portal/portals/kde.portal -
> > > /usr/libexec/xdg-desktop-portal-kde
> > > 
> > > 
> > > I guess based on the log that the dbus service is important to have in
> > > correct place.
> > 
> > Thanks, this helped a bit. I had a relative path in the Exec entry of the
> > .service file. Using an absolute path fixes the file dialogs, though I
> > still don't get native notifications.
> 
> Any debug output from xdg-desktop-portal-kde or xdg-desktop-portal?

Nevermind, I reinstalled my kde runtime and now notifications work fine...

Speaking of notifications, in notification.cpp I noticed:

        // TODO KNotification has no option for default action

but that's no longer true as of KNotifications 5.31: https://cgit.kde.org/
knotifications.git/commit/?id=8b161b971fae41e60a2d8093843c3fbae2429c07

Other than that, looks good to me :)

Cheers,
Elvis

> 
> > Btw it seems archlinux is using /usr/lib rather than /usr/libexec (the
> > gnome portal installs /usr/lib/xdg-desktop-portal-gtk).
> > 
> > > > > > >> Another thing, shouldn't we renamed it to
> > > > > > >> xdg-desktop-portal-plasma?
> > > > > > >> (at least the repository/package, which is what the end user is
> > > > > > >> going
> > > > > > >> to install).
> > > > > > > 
> > > > > > > Not sure, gnome folks use xdg-desktop-portal-gtk because it's
> > > > > > > only
> > > > > > > gtk
> > > > > > > related and not tied to Gnome, but we use both Qt and KDE
> > > > > > > Frameworks
> > > > > > > so
> > > > > > > I
> > > > > > > decided to go for xdg-desktop-portal-kde, there is nothing
> > > > > > > really
> > > > > > > Plasma
> > > > > > > specific.
> > > > > > 
> > > > > > The point is to integrate flatpak Qt applications with Plasma, no?
> > > > > > (plasma file picker, plasma notifications, etc.)
> > > > > > Or I can use this portal also to integrate a Qt application with,
> > > > > > say,
> > > > > > LXQt?>