kdereview - xdg-desktop-portal-kde

[Elvis Angelaccio]

On martedì 2 maggio 2017 17:26:41 CEST Jan Grulich wrote:
> On úterý 2. května 2017 15:22:23 CEST Elvis Angelaccio wrote:
> > On Tue, May 2, 2017 at 3:09 PM, Jan Grulich <jgrulich at redhat.com> wrote:
> > > On úterý 2. května 2017 14:19:04 CEST Elvis Angelaccio wrote:
> > >> On Tue, May 2, 2017 at 12:36 PM, Jan Grulich <jgrulich at redhat.com> 
wrote:
> > >> > On úterý 2. května 2017 12:21:31 CEST Aleix Pol wrote:
> > >> >> On Tue, May 2, 2017 at 12:15 PM, Albert Astals Cid <aacid at kde.org>
> 
> wrote:
> > >> >> > El dimarts, 2 de maig de 2017, a les 7:22:04 CEST, Jan Grulich va
> > >> > 
> > >> > escriure:
> > >> >> >> On pondělí 1. května 2017 22:59:44 CEST Albert Astals Cid wrote:
> > >> >> >> > El divendres, 21 d’abril de 2017, a les 8:10:36 CEST, Jan
> > >> >> >> > Grulich
> > >> >> >> > va
> > >> >> >> 
> > >> >> >> escriure:
> > >> >> >> > > Hi,
> > >> >> >> > > 
> > >> >> >> > > I would like to request review of xdg-desktop-portal-kde [1].
> > >> >> >> > > We
> > >> >> >> > > would
> > >> >> >> > > like
> > >> >> >> > > to make it part of Plasma releases, see [2].
> > >> >> >> > > 
> > >> >> >> > > What is xdg-desktop-portal-kde:
> > >> >> >> > > It's a KDE implementation of Flatpak portals backend [3],
> > >> >> >> > > currently
> > >> >> >> > > with
> > >> >> >> > > support of AppChooser, FileChooser, Notification and Print
> > >> >> >> > > portals.
> > >> >> >> > > 
> > >> >> >> > > One mentioned issue on plasma-devel mailing list was usage of
> > >> >> >> > > Qt's
> > >> >> >> > > private
> > >> >> >> > > print API. This will most likely go away if I find out it's
> > >> >> >> > > useless,
> > >> >> >> > > otherwise I'll have to keep it as it's used to set CUPS
> > >> >> >> > > properties
> > >> >> >> > > which
> > >> >> >> > > are not available to the outside world.
> > >> 
> > >> Hi, doesn't seem to work here. If I click Open in your test app I get:
> > >> 
> > >> qt.qpa.qflatpakplatform.FileDialog: File dialog: selectedNameFilter()
> > >> qt.qpa.qflatpakplatform.FileDialog: File dialog: selectedFiles()
> > >> qt.qpa.qflatpakplatform.FileDialog: File dialog: show()
> > >> qt.qpa.qflatpakplatform.FileDialog: File dialog: initializeDialog()
> > >> qt.qpa.qflatpakplatform.FileDialog: Initial values:
> > >> qt.qpa.qflatpakplatform.FileDialog:        Multiple files:  true
> > >> qt.qpa.qflatpakplatform.FileDialog:          Accept label:  "Open
> > >> (portal)"
> > >> qt.qpa.qflatpakplatform.FileDialog:           Window title:  "Flatpak
> > >> test - open dialog"
> > >> qt.qpa.qflatpakplatform.FileDialog:             Save/Open:  Open
> > >> qt.qpa.qflatpakplatform.FileDialog:          Name filters:  ("plain
> > >> text document (*.txt *.asc *,v *.doc)", "PNG image (*.png)")
> > >> qt.qpa.qflatpakplatform.FileDialog:     MimeTypes filters:
> > >> ("text/plain", "image/png")
> > >> qt.qpa.qflatpakplatform.FileDialog:     Initial directory:
> > >> "file:///home/elvis" qt.qpa.qflatpakplatform.FileDialog: File dialog:
> > >> exec()
> > >> qt.qpa.qflatpakplatform.FileDialog: Couldn't get reply
> > >> qt.qpa.qflatpakplatform.FileDialog: Error:  "Did not receive a reply.
> > >> Possible causes include: the remote application did not send a reply,
> > >> the message bus security policy blocked the reply, the reply timeout
> > >> expired, or the network connection was broken."
> > >> 
> > >> but I don't see any file dialog (the app just freezes). Not sure if
> > >> related, but I also have xdg-desktop-portal-gtk installed.
> > > 
> > > Do you have xdg-desktop-portal installed?
> > 
> > Yes.
> 
> Make sure that xdg-desktop-portal is running, it should be started
> automatically by flatpak, but you never know. 

How do I check it? Is it a process that I should see?

> Also try to run xdg-desktop-
> portal-kde with debug enabled using:
> QT_LOGGING_RULES=xdg-desktop-portal-kde*.debug=true /path/to/xdg-desktop-
> portal-kde.

This just prints "Desktop portal registered successfuly", which I guess is ok.

As soon as the test app freezes (instead of opening the file dialog), I get 
this in my journalctl: https://paste.kde.org/phcnn4uxn

> 
> > >> Another thing, shouldn't we renamed it to xdg-desktop-portal-plasma?
> > >> (at least the repository/package, which is what the end user is going
> > >> to install).
> > > 
> > > Not sure, gnome folks use xdg-desktop-portal-gtk because it's only gtk
> > > related and not tied to Gnome, but we use both Qt and KDE Frameworks so
> > > I
> > > decided to go for xdg-desktop-portal-kde, there is nothing really Plasma
> > > specific.
> > 
> > The point is to integrate flatpak Qt applications with Plasma, no?
> > (plasma file picker, plasma notifications, etc.)
> > Or I can use this portal also to integrate a Qt application with, say,
> > LXQt?> 
> > > Jan
> > 
> > Elvis