Elisa is in kdereview

[Albert Astals Cid]

El divendres, 16 de juny de 2017, a les 22:44:03 CEST, Matthieu Gallien va escriure:
> Hello,
> 
> Elisa is now in kdereview and aiming for extragear/multimedia.
> 
> It is a music player from a design from Andrew Lake.
> It is using Qt multimedia for playback and a few KDE frameworks. Its UI is
> using Qml.
> 
> Its aim is to be simple to use and hopefully in the future powerfull when
> needed.
> 
> It should be usable without needing online services but will use them in the
> future.
> 
> A few integration bits are missing with respect to Baloo before I can do a
> release. Currently music can only be read if in its database that can be
> filled by Baloo or a custom file indexer if Baloo is not there.
> 
> A broken and experimental support for UPnP DLNA exists and depends on an
> external library not yet in KDE.
> 
> If the review succeed, I would like to have CI support for Elisa.
> 
> Thanks in advance for any review as this my first "real" project with Qml
> and Qt.

Doesn't compile.

/home/kdeunstable/elisa/src/baloo/localbaloofilelisting.cpp: In member function ‘virtual MusicAudioTrack LocalBalooFileListing::scanOneFile(const QUrl&)’:
/home/kdeunstable/elisa/src/baloo/localbaloofilelisting.cpp:153:50: error: ‘DiscNumber’ is not a member of ‘KFileMetaData::Property’
     auto discNumberProperty = allProperties.find(KFileMetaData::Property::DiscNumber);

I guess you need to increase some of your dependencies version requirements?

Cheers,
  Albert


> 
> Best regards