kio-stash is in KDE Review

Mon Jun 19 22:08:00 BST 2017

El dilluns, 19 de juny de 2017, a les 10:06:35 CEST, Jonathan Riddell va 
escriure:
> Better as kio-extras in KDE Applications no?

I've no idea, the original email didn't explain what kio-stash is.

Ok, i went and read the README.md to me it really sounds really specialized, 
but if the world wants it in kio-extras i won't complain much.

Cheers,
  Albert

> 
> Jonathan
> 
> On 19 June 2017 at 10:00, Arnav Dhamija <arnav.dhamija at gmail.com> wrote:
> > Thanks. I have fixed this and the kio-stash ioslave passes all the
> > test cases on CI here:
> > https://build-sandbox.kde.org/view/Extragear/job/Extragear%20kio-stash%20k
> > f5-qt5%20SUSEQt5.9/
> > 
> > The build log for the same can be found here:
> > https://build-sandbox.kde.org/view/Extragear/job/Extragear%20kio-stash%20k
> > f5-qt5%20SUSEQt5.9/11/timestamps/?time=HH:mm:ss&appendLog&locale=en_US
> > 
> > I feel the ioslave is now ready to be shipped. The question is if it
> > can be included as part of KDE Frameworks for the next major release
> > or if it should be a separate package only in KDE Extra gear.
> > 
> > On Mon, Jun 19, 2017 at 3:07 AM, Albert Astals Cid <aacid at kde.org> wrote:
> >> El dimecres, 14 de juny de 2017, a les 21:42:58 CEST, Arnav Dhamija va
> >> 
> >> escriure:
> >>> Just to check I setup a brand new virtualbox with KDE Neon 5.8 LTS and
> >>> ran the following commands after cloning the repo and creating a build
> >>> directory:
> >>> 
> >>> cmake -DCMAKE_INSTALL_PREFIX=/usr -DKDE_INSTALL_USE_QT_SYS_PATHS=TRUE ..
> >>> make
> >> 
> >> git code does not compile as of now.
> >> 
> >> Cheers,
> >> 
> >>   Albert
> >>> 
> >>> sudo make install
> >>> kdeinit5
> >>> 
> >>> ..and then I ran the tests using 'ctest -v'. It passed slavetest with
> >>> no issues (18 out of 18 tests passed). My guess why it doesn't work
> >>> you is because you haven't run kdeinit5 after installing the ioslave.
> >>> If not that, the testdaemon process might not have been successfully
> >>> registered on the system D-Bus when thes test is run.
> >>> 
> >>> Is there a way I can see if my test cases pass on KDE's CI
> >>> infrastructure to narrow down the problem? If so, I will a sysadmin to
> >>> do so.
> >>> 
> >>> On Tue, Jun 13, 2017 at 4:16 AM, Albert Astals Cid <aacid at kde.org> 
wrote:
> >>> > El divendres, 9 de juny de 2017, a les 11:45:14 CEST, Arnav Dhamija va
> >>> > 
> >>> > escriure:
> >>> >> > Do you mean i have to manually start a process for the tests to
> >>> >> > succeed?
> >>> >> 
> >>> >> If installed correctly with kdeinit restarted and the Stash Daemon is
> >>> >> running in kded5, it is not required. However, I cannot recall what
> >>> >> steps are needed for this to happen as I think it requires a system
> >>> >> restart or logout to do so.
> >>> >> 
> >>> >> Hence, I have created a fallback testdaemon program which creates a
> >>> >> daemon process for the Stash Daemon to run. This is launched
> >>> >> automatically by the test suite if the test suite cannot find the
> >>> >> Stash Daemon running in kded. I just patched it so that it finds the
> >>> >> path to the testdaemon program correctly (it had the wrong path when
> >>> >> you tested it). It should pass the test cases now with no manual
> >>> >> invocation of the testdaemon process.
> >>> > 
> >>> > Doesn't seem to work for me.
> >>> > 
> >>> > https://paste.kde.org/ptnn5hhkt
> >>> > 
> >>> > Cheers,
> >>> > 
> >>> >   Albert
> >>> >> 
> >>> >> On Fri, Jun 9, 2017 at 1:47 AM, Albert Astals Cid <aacid at kde.org> 
wrote:
> >>> >> > El dijous, 8 de juny de 2017, a les 16:25:02 CEST, Arnav Dhamija va
> >>> > 
> >>> > escriure:
> >>> >> >> Yes, I will file a sysadmin ticket for the same. Until I do so,
> >>> >> >> could
> >>> >> >> you send me the output of the test suite in a screenshot or as
> >>> >> >> plain
> >>> >> >> text?
> >>> >> >> 
> >>> >> >> The ioslave works by storing a list of virtual files and folders
> >>> >> >> in a
> >>> >> >> process running in the KDED, communicating with it over D-Bus.
> >>> >> >> Hence,
> >>> >> >> some of the tests won't work unless a) the testdaemon process is
> >>> >> >> started
> >>> >> > 
> >>> >> > Do you mean i have to manually start a process for the tests to
> >>> >> > succeed?
> >>> >> > 
> >>> >> > If that is the case, that's not acceptable.
> >>> >> > 
> >>> >> > Cheers,
> >>> >> > 
> >>> >> >   Albert
> >>> >> >> 
> >>> >> >> or b) the Stash KIO slave watcher is running in KDED. Usually
> >>> >> >> it requires a restart of KDED and a kdeinit after installing the
> >>> >> >> ioslave to have the Stash daemon running in KDED.
> >>> >> >> 
> >>> >> >> On Thu, Jun 8, 2017 at 3:42 AM, Albert Astals Cid <aacid at kde.org>
> >> 
> >> wrote:
> >>> >> >> > El divendres, 26 de maig de 2017, a les 22:55:11 CEST, Arnav
> >>> >> >> > Dhamija
> >>> >> >> > va
> >>> >> >> > 
> >>> >> >> > escriure:
> >>> >> >> >> Hi!
> >>> >> >> >> 
> >>> >> >> >> I had made the kio-stash ioslave last year as part of my GSoC
> >>> >> >> >> 2016
> >>> >> >> >> Project. Now that most of the changes which I wished to make in
> >>> >> >> >> Dolphin relevant to the ioslave are part of master, I wish to
> >>> >> >> >> ship
> >>> >> >> >> the
> >>> >> >> >> ioslave soon.
> >>> >> >> >> 
> >>> >> >> >> The project is now in KDE review and is awaiting feedback. The
> >>> >> >> >> link
> >>> >> >> >> for the same can be found here:
> >>> >> >> >> https://phabricator.kde.org/R247:0f4dc333ac8469b36d1b3a1cedd0a6
> >>> >> >> >> 672a
> >>> >> >> >> c90
> >>> >> >> >> 7b8
> >>> >> >> >> 
> >>> >> >> >> The source of the project can be found here:
> >>> >> >> >> https://cgit.kde.org/kio-stash.git/
> >>> >> >> > 
> >>> >> >> > Can you please get it covered by the CI?
> >>> >> >> > 
> >>> >> >> > I have some of the tests failing but don't know if it is because
> >>> >> >> > my
> >>> >> >> > setup
> >>> >> >> > is a bit broken at this moment, so wanted to check in CI if the
> >>> >> >> > tests
> >>> >> >> > were file but I have not been able to find it there.
> >>> >> >> > 
> >>> >> >> > Cheers,
> >>> >> >> > 
> >>> >> >> >   Ablert
> >>> >> >> >> 
> >>> >> >> >> Thanks.
> > 
> > --
> > arnav dhamija