libqaccessibilityclient now in kdereview

[Frederik Gladhorn]

On tirsdag 25. juli 2017 14.47.44 CEST Albert Astals Cid wrote:
> El dimarts, 25 de juliol de 2017, a les 13:25:39 CEST, Jonathan Riddell va
> 
> escriure:
> > libqaccessibilityclient is now in kdereview.  It's in a git repo
> > called libkdeaccessibilityclient but we filed a sysadmin request to
> > rename it.
> > 
> > We just released 0.2.0 in unstable (for some reason 0.1.1 was released
> > in stable some years ago).
> 
> What's your target? Frameworks? KDE Applications? Independent release?

It's closest to being a framework, considering that it's a tiny helper lib.

> 
> 
> It seems to have autotests but they are not run by either of these
>   ctest
>   make check
>   make test

Will look into that, thanks for the feedback!

Cheers,
Frederik

> 
> 
> 
> 
> AccessibleObject seems like a dumping group, having functions like
> 	double maximumValue() const;
> and
>     QString imageDescription() const;
> that if you read the description seems to me like they apply to "different
> types" of objects. Is it because it is mimic-ing the ATSPI API? Is there a
> way to have these things more split so they are grouped together more
> logically?
> 
> 
> 
>     Interfaces supportedInterfaces() const;
> documentation is wrong, it says "return QStringList"
> 
> 
> Can we remove the commented functions, i.e. managesDescendants, isRequired,
> etc.?
> 
> 
> Thanks for pushing this forward :)
> 
> 
> Cheers,
>   Albert
> 
> > What is it?
> > ========
> > Since it's hard to grasp all the bits related to accessibility, I'll try
> > to
> > explain what the lib is for.
> > Most of the stack is part of Qt 5, so nothing to worry about, that's the
> > part that lets applications expose their UI over DBus for AT-SPI, so they
> > work nicely with assisitve tools (e.g. Orca). In accessibility language,
> > the applications act as "servers" and the screen reader for example is a
> > client.
> > 
> > This library is for writing clients, so applications that are assistive,
> > such as screen readers. It currently has two users: KMag and Simon.
> > KMag can use it to follow the focus (e.g. when editing text, it can
> > automatically magnify the part of the document where the cursor is.
> > 
> > For Simon Listens, the use is to be able to let the user trigger menus and
> > buttons by voice input.